Skip to content

Conversation

@FedericoNegri
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 2, 2023
@FedericoNegri FedericoNegri added the enhancement New features or code improvements label Mar 2, 2023
@FedericoNegri FedericoNegri marked this pull request as ready for review March 2, 2023 17:45
@FedericoNegri FedericoNegri requested a review from ojkoenig March 2, 2023 17:45
Copy link
Contributor

@ojkoenig ojkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy to expose the ability to update evaluator configs.

When looking at your example one wonders though if this special update mechanism is needed in this case with the separate 'configuration_updates' field instead of a regular PUT.
I guess this done that way currently so that the evaluator can lookup the changes in config it should pickup. Maybe this could be simplified in the future.

@FedericoNegri
Copy link
Contributor Author

Fancy to expose the ability to update evaluator configs.

When looking at your example one wonders though if this special update mechanism is needed in this case with the separate 'configuration_updates' field instead of a regular PUT. I guess this done that way currently so that the evaluator can lookup the changes in config it should pickup. Maybe this could be simplified in the future.

To my understanding this is currently needed because the evaluator itself periodically pushes its current configuration to JMS at this very same endpoint. This makes the configuration field somewhat reserved for the evaluator.

@FedericoNegri FedericoNegri merged commit c4a61a6 into main Mar 3, 2023
@FedericoNegri FedericoNegri deleted the fnegri/eval_config branch March 7, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants