Skip to content

Conversation

@wehrler
Copy link
Contributor

@wehrler wehrler commented Apr 19, 2023

Removed file storage from project schema and refactored project api file storage logic.

@FedericoNegri
Copy link
Contributor

Since the storage is now an endpoint at the root level (corresponding to JmsApi), I think we should:

  • add a JmsApi.get_storage() method that simply returns the json response (let's not add schemas for this)
  • move project_api.get_fs_url to jms_api, it should now take JmsApi as argument
  • expose a property fs_url in both JmsApi and ProjectApi

Expose fs_url on jms api;
Create method to retrieve storages
@wehrler
Copy link
Contributor Author

wehrler commented Apr 21, 2023

Since the storage is now an endpoint at the root level (corresponding to JmsApi), I think we should:

  • add a JmsApi.get_storage() method that simply returns the json response (let's not add schemas for this)
  • move project_api.get_fs_url to jms_api, it should now take JmsApi as argument
  • expose a property fs_url in both JmsApi and ProjectApi

@FedericoNegri - *see latest implementation. Note - I changed the arguments to get_fs_url to match the pattern in jms api.

@FedericoNegri
Copy link
Contributor

Since the storage is now an endpoint at the root level (corresponding to JmsApi), I think we should:

  • add a JmsApi.get_storage() method that simply returns the json response (let's not add schemas for this)
  • move project_api.get_fs_url to jms_api, it should now take JmsApi as argument
  • expose a property fs_url in both JmsApi and ProjectApi

@FedericoNegri - *see latest implementation. Note - I changed the arguments to get_fs_url to match the pattern in jms api.

@wehrler Looks good to me. Once backend changes are in we can move on with this one as well. Before that, let's quickly discuss whether it's worth bumping version.

@wehrler wehrler marked this pull request as ready for review April 26, 2023 12:30
@github-actions github-actions bot added the maintenance Package and maintenance related label May 10, 2023
@nezgrath nezgrath self-requested a review May 10, 2023 11:04
@FedericoNegri FedericoNegri merged commit bf79e51 into main May 10, 2023
@FedericoNegri FedericoNegri deleted the wehrler/storage_configuration_refactor branch June 29, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants