Skip to content

Conversation

@wehrler
Copy link
Contributor

@wehrler wehrler commented May 25, 2023

No description provided.

@FedericoNegri
Copy link
Contributor

@wehrler I've pushed a commit to enhance the script that auto-generates the resources code so to include more dict type info.

Here as well would be good to cover your changes with tests (mostly to cover correct serialization and deserialization, and verify that the schema rejects unsupported types already at client level).

@wehrler
Copy link
Contributor Author

wehrler commented May 30, 2023

@wehrler I've pushed a commit to enhance the script that auto-generates the resources code so to include more dict type info.

Here as well would be good to cover your changes with tests (mostly to cover correct serialization and deserialization, and verify that the schema rejects unsupported types already at client level).

Do we want tests targeting the schema adjustments in general? (e.g. The tests for JMS target the new any_value field that I created. I chose this instead of the fields where it is applied due to the coupling of TaskDefintionSchema to an actual request session.)

@wehrler wehrler marked this pull request as ready for review May 30, 2023 19:09
@wehrler
Copy link
Contributor Author

wehrler commented May 31, 2023

@wehrler I've pushed a commit to enhance the script that auto-generates the resources code so to include more dict type info.
Here as well would be good to cover your changes with tests (mostly to cover correct serialization and deserialization, and verify that the schema rejects unsupported types already at client level).

Do we want tests targeting the schema adjustments in general? (e.g. The tests for JMS target the new any_value field that I created. I chose this instead of the fields where it is applied due to the coupling of TaskDefintionSchema to an actual request session.)

@FedericoNegri - *see latest. (I added a test for de/serialization of task definitions).

@wehrler wehrler merged commit e767dda into main Jun 1, 2023
@FedericoNegri FedericoNegri deleted the wehrler/typed_dict_schema_adjustments branch June 29, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants