Skip to content

Conversation

@FedericoNegri
Copy link
Contributor

@FedericoNegri FedericoNegri commented Nov 16, 2023

  • Exposing RMS as a new API next to JmsApi, ProjectApi and AuthApi
  • New RmsApi object with basic endpoints for evaluators, scalers, and compute resource sets. Same syntax as JmsApi and AuthApi
  • Auto-generated pydantic models instead of hand-crafted marshmallow schemas + resource objects:
    • requires additional dependency: pydantic
    • inconsistent behavior wrt other apis; especially: unset fields get defaulted rather than marked as missing
  • RmsApi doc already included
  • Supports both pydantic v1 and v2

Checklist

Please complete the following checklist before submitting your pull request:

  • I have tested these changes locally and verified that they work as intended.
  • I have updated any documentation as needed to reflect these changes (if appropriate)
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.
  • Unit tests have been added (if appropriate)
  • Test-cases have been added (if appropriate)
  • Testing instructions have been added (if appropriate)

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Related with project dependencies maintenance Package and maintenance related labels Nov 16, 2023
@FedericoNegri FedericoNegri changed the title [WIP] Expose the resource management service (RMS) api [WIP] Expose the resource management service (RMS) API Nov 16, 2023
@FedericoNegri FedericoNegri changed the title [WIP] Expose the resource management service (RMS) API Expose the resource management service (RMS) API Nov 17, 2023
@FedericoNegri FedericoNegri marked this pull request as ready for review November 17, 2023 16:34
@FedericoNegri FedericoNegri merged commit 2201ab4 into main Nov 20, 2023
@FedericoNegri FedericoNegri deleted the fnegri/evals_rms branch November 20, 2023 23:35
@FedericoNegri FedericoNegri linked an issue Nov 21, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose RMS

3 participants