Skip to content

Fix checks in project permissions tests #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Fix checks in project permissions tests #448

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/jms/test_project_permissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def test_get_project_permissions(client):
proj = jms_api.create_project(proj, replace=True)
project_api = ProjectApi(client, proj.id)

perms = project_api.get_permissions()
perms = [p for p in project_api.get_permissions() if p.permission_type == "user"]
assert len(perms) == 1
assert perms[0].value_name == client.username
assert perms[0].role == "admin"
Expand Down Expand Up @@ -140,7 +140,7 @@ def test_modify_project_permissions(client, keycloak_client):

# user1 shares the project with user2
grant_permissions(project_api, user2)
permissions = project_api.get_permissions()
permissions = [p for p in project_api.get_permissions() if p.permission_type == "user"]
assert len(permissions) == 2
assert user1.username in [x.value_name for x in permissions]
assert user2.username in [x.value_name for x in permissions]
Expand All @@ -162,7 +162,7 @@ def test_modify_project_permissions(client, keycloak_client):

# user1 removes permissions to user2
remove_permissions(project_api, user2)
permissions = project_api.get_permissions()
permissions = [p for p in project_api.get_permissions() if p.permission_type == "user"]
assert len(permissions) == 1
assert user1.username in [x.value_name for x in permissions]
assert user2.username not in [x.value_name for x in permissions]
Expand Down