Skip to content

Improve type annotations and APIs doc #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2022
Merged

Improve type annotations and APIs doc #47

merged 1 commit into from
Sep 8, 2022

Conversation

@FedericoNegri
Copy link
Contributor

@FedericoNegri FedericoNegri commented Sep 7, 2022

  • Add type annotations to API functions
  • Improve APIs doc
  • Move base schema and resource classes from ansys.rep.client.jms to a new ansys.rep.client.common subpackage because a) they're shared between different APIs and b) to avoid circular imports

@github-actions github-actions bot added dependencies Related with project dependencies documentation Improvements or additions to documentation labels Sep 7, 2022
@FedericoNegri FedericoNegri linked an issue Sep 7, 2022 that may be closed by this pull request
Type annotations for API functions #43
Closed
@FedericoNegri FedericoNegri marked this pull request as ready for review September 8, 2022 04:20
@FedericoNegri FedericoNegri merged commit 051a291 into main Sep 8, 2022
@FedericoNegri FedericoNegri deleted the fnegri/type_annotations branch September 14, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ojkoenig ojkoenig ojkoenig approved these changes

Assignees

No one assigned

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type annotations for API functions

3 participants

@FedericoNegri @ojkoenig