-
Notifications
You must be signed in to change notification settings - Fork 0
Implement and document compatibility with HPS releases #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 87.21% 87.58% +0.36%
==========================================
Files 64 65 +1
Lines 2840 2900 +60
==========================================
+ Hits 2477 2540 +63
+ Misses 363 360 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ojkoenig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at the PR, two comments:
-
Do we need to do that magic with static dicts to map from HPS version to JMS/RMS version? This adds another place where new versions will need to be added manually as we create new, and I guess what we want to do is check against global HPS version?
Is the reason that you cannot query hps version easily? -
For RMS you seem to add version check functionality but not using it? Or did I miss something?
|
I agree that service registry would be the place where HPS version could be queried, once we have one.
ok |
ojkoenig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answered your last comments
Uh oh!
There was an error while loading. Please reload this page.