Skip to content

Conversation

@FedericoNegri
Copy link
Contributor

@FedericoNegri FedericoNegri commented Mar 26, 2025

  • replace black, isort and flake8 with ruff
  • enable many additional rules (doc string style, language best practices, etc.)

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Related with project dependencies maintenance Package and maintenance related labels Mar 26, 2025
@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 94.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 87.50%. Comparing base (6c2d302) to head (441b474).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/hps/client/jms/api/project_api.py 87.30% 8 Missing ⚠️
src/ansys/hps/client/exceptions.py 25.00% 6 Missing ⚠️
src/ansys/hps/client/client.py 80.95% 4 Missing ⚠️
src/ansys/hps/client/rms/api/base.py 72.72% 3 Missing ⚠️
src/ansys/hps/client/common/base_resource.py 66.66% 1 Missing ⚠️
src/ansys/hps/client/connection.py 66.66% 1 Missing ⚠️
src/ansys/hps/client/rms/api/rms_api.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   87.62%   87.50%   -0.13%     
==========================================
  Files          65       65              
  Lines        2908     2880      -28     
==========================================
- Hits         2548     2520      -28     
  Misses        360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FedericoNegri FedericoNegri marked this pull request as ready for review March 26, 2025 09:46
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes seem reasonable - nice change @FedericoNegri!

@FedericoNegri FedericoNegri linked an issue Mar 26, 2025 that may be closed by this pull request
@FedericoNegri FedericoNegri merged commit fe56f63 into main Mar 26, 2025
22 checks passed
@FedericoNegri FedericoNegri deleted the maint/ruff branch March 26, 2025 10:55
FedericoNegri added a commit that referenced this pull request Mar 26, 2025
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace isort and black with ruff

4 participants