Dont ever assume the path from the HPS url, always work from the auth_url #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
We need to merge this and then poetry update scaler from the latest pyHPS before the bug is resolved. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 65 65
Lines 2999 2999
=======================================
Hits 2628 2628
Misses 371 371 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
FedericoNegri
approved these changes
Jul 28, 2025
Contributor
FedericoNegri
left a comment
FedericoNegri
left a comment
There was a problem hiding this comment.
Fine with me, can you please just remove the commented code? thanks
FedericoNegri
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When supporting the use case for Fuji, we are using impersonation with a different keycloak location, we need to avoid assuming that its in a static location next to other HPS services.
https://github.com/ansys-internal/rep-scaling/issues/718
Checklist