Skip to content

Conversation

@Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Dec 6, 2022

Fix #1663

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc Maintenance labels Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

Please add one of the following labels to add this contribution to the Release Notes 👇

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #1674 (e0399c2) into main (579b7ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1674   +/-   ##
=======================================
  Coverage   85.21%   85.21%           
=======================================
  Files          45       45           
  Lines        7466     7466           
=======================================
  Hits         6362     6362           
  Misses       1104     1104           

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review December 6, 2022 16:12
@jorgepiloto
Copy link
Member

I think this pull-request is in the right path. Let us take advantage of the current work, apply double quotes in strings and simplify as much as possible the CI pipelines while still providing the same quality.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jorgepiloto jorgepiloto force-pushed the maint/update-to-pyansys-actions branch 3 times, most recently from bd3b53d to 1ffee57 Compare December 7, 2022 10:12
@jorgepiloto jorgepiloto force-pushed the maint/update-to-pyansys-actions branch from 1ffee57 to 9be984e Compare December 7, 2022 10:21
@jorgepiloto jorgepiloto force-pushed the maint/update-to-pyansys-actions branch from 9be984e to 0da4fa0 Compare December 7, 2022 10:36
@jorgepiloto jorgepiloto force-pushed the maint/update-to-pyansys-actions branch from bcc59b4 to 4d570b8 Compare December 7, 2022 11:41
@jorgepiloto jorgepiloto force-pushed the maint/update-to-pyansys-actions branch from 4d570b8 to bd2663c Compare December 7, 2022 11:53
@jorgepiloto jorgepiloto changed the title Update to pyansys actions and adapt to multi-documentation. DOC: implement multi-version in main Dec 7, 2022
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for this!

@germa89 germa89 merged commit 6594b7a into main Dec 7, 2022
@germa89 germa89 deleted the maint/update-to-pyansys-actions branch December 7, 2022 12:54
Revathyvenugopal162 added a commit that referenced this pull request Dec 7, 2022
* WIP: migrate to pyansys actions

* WIP: Add release actions

* WIP: rename package name in favour of release actions

* WIP: refactor the deployment

* WIP: refactor the actions order

* WIP: Adapt conf for the multidoc

* resolves code style error

* Update .github/workflows/ci.yml

Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>

* WIP: Change build file for pdf build

* DBG: show latex dir

* CI: apply double quotes

* CI: fix cache doc/_build

* WIP: Change _build in validate png module

* Update theme

* change the html docs name

* Update the actions to 2

* MAINT: use ansys-sphinx-theme==0.8.0

* Add build env

* Add build env

* CI: fix double quotes

* Adapt to double quotes

* fix typo

* DBG: avoid cache

* DBG: avoid cache

* Resolves the package check actions

* CI: update nightly docs

Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
Co-authored-by: Jorge Martinez Garrido <jorge.martinezgarrido@ansys.com>
jorgepiloto added a commit that referenced this pull request Dec 8, 2022
* DOC: implement multi-version in main (#1674)

* WIP: migrate to pyansys actions

* WIP: Add release actions

* WIP: rename package name in favour of release actions

* WIP: refactor the deployment

* WIP: refactor the actions order

* WIP: Adapt conf for the multidoc

* resolves code style error

* Update .github/workflows/ci.yml

Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>

* WIP: Change build file for pdf build

* DBG: show latex dir

* CI: apply double quotes

* CI: fix cache doc/_build

* WIP: Change _build in validate png module

* Update theme

* change the html docs name

* Update the actions to 2

* MAINT: use ansys-sphinx-theme==0.8.0

* Add build env

* Add build env

* CI: fix double quotes

* Adapt to double quotes

* fix typo

* DBG: avoid cache

* DBG: avoid cache

* Resolves the package check actions

* CI: update nightly docs

Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
Co-authored-by: Jorge Martinez Garrido <jorge.martinezgarrido@ansys.com>

* FIX: gh_token scope (#1679)

* Modify package name

* Modify pre-commit

* Modify pre-commit

* revert changes with ci/cd yml

* revert changes with ci/cd yml

* Add reelase docs

* Apply suggestions from code review

* Add correct build path

* Add requirement

* Correcting path for tar logs

* Take out the bot

* FIX: do not update pyproject.toml

Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
Co-authored-by: Jorge Martinez Garrido <jorge.martinezgarrido@ansys.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable multi-version documentation

4 participants