Skip to content

feat: allowing passing IP to MapdlPool - #3048

Merged
germa89 merged 8 commits into
mainfrom
feat/allow-passing-ip-to-MapdlPool
May 3, 2024
Merged

germa89 merged 8 commits into
mainfrom
feat/allow-passing-ip-to-MapdlPool

Conversation

@germa89

@germa89 germa89 commented Apr 30, 2024

Copy link
Copy Markdown
Collaborator

As the title.

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter

codecov-commenter commented Apr 30, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 84.16%. Comparing base (42ef513) to head (08c4ca8).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3048      +/-   ##
==========================================
- Coverage   86.68%   84.16%   -2.52%     
==========================================
  Files          52       52              
  Lines        9498     9553      +55     
==========================================
- Hits         8233     8040     -193     
- Misses       1265     1513     +248     

@germa89 germa89 self-assigned this Apr 30, 2024
@germa89
germa89 requested review from Gryfenfer97 and clatapie April 30, 2024 15:04
Comment thread tests/test_pool.py Outdated
@germa89
germa89 enabled auto-merge (squash) May 3, 2024 08:14

@clatapie clatapie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89
germa89 merged commit f6224a5 into main May 3, 2024
@germa89
germa89 deleted the feat/allow-passing-ip-to-MapdlPool branch May 3, 2024 10:26
@clatapie clatapie changed the title Allowing passing IP to MapdlPool feat: allowing passing IP to MapdlPool Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants