Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 25, 2024

Description

Update requirements in the .devcontainer directory. I believe some were outdated because dependabot directory mess.

Issue linked

NA

Checklist

germa89 added 2 commits June 25, 2024 18:56
Removing 'trame' for 'jupyter' optional dependency
@germa89 germa89 requested a review from a team as a code owner June 25, 2024 17:01
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jun 25, 2024
@germa89 germa89 added dependencies maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 25, 2024
@germa89 germa89 enabled auto-merge (squash) June 25, 2024 17:02
@codecov
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.21%. Comparing base (587a0cb) to head (a5633f4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3217      +/-   ##
==========================================
+ Coverage   82.67%   84.21%   +1.54%     
==========================================
  Files          53       53              
  Lines        9625     9625              
==========================================
+ Hits         7957     8106     +149     
+ Misses       1668     1519     -149     

@germa89
Copy link
Collaborator Author

germa89 commented Jun 27, 2024

The name of the branch is incorrect, but I'm not going to change it at this point.

Please @clatapie review whenever you can.

auto-merge was automatically disabled June 28, 2024 16:58

Pull Request is not mergeable

@github-actions github-actions bot added the CI/CD Related with CICD, Github Actions, etc label Jul 8, 2024
@germa89 germa89 changed the title build: update-requirements-in-devcontainer-directory build: update requirements in devcontainer directory Jul 8, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Jul 8, 2024

@pyansys-ci-bot LGTM!

@germa89 germa89 enabled auto-merge (squash) July 8, 2024 14:58
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 5a993db into main Jul 8, 2024
@germa89 germa89 deleted the maint--update-requirements-in-devcontainer-directory branch July 8, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants