Skip to content

docs: documenting new naming conventions for commits, branches and PRs.#3228

Merged
germa89 merged 13 commits intomainfrom
docs/document-new-naming-conventions-for-commits,-branches-and-PRs
Jul 1, 2024
Merged

docs: documenting new naming conventions for commits, branches and PRs.#3228
germa89 merged 13 commits intomainfrom
docs/document-new-naming-conventions-for-commits,-branches-and-PRs

Conversation

@germa89
Copy link
Copy Markdown
Collaborator

@germa89 germa89 commented Jun 27, 2024 •
edited
Loading

Description

As the title. I want to have everything clearly stated in the PyMAPDL development section.

Issue linked

Close #3218

Checklist

@germa89 germa89 requested a review from a team as a code owner June 27, 2024 16:35
@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

ansys-reviewer-bot Bot commented Jun 27, 2024

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the documentation Documentation related (improving, adding, etc) label Jun 27, 2024
@germa89 germa89 self-assigned this Jun 27, 2024
@germa89 germa89 requested review from PipKat and klmcadams June 27, 2024 16:37
@germa89 germa89 enabled auto-merge (squash) June 27, 2024 16:37
@germa89 germa89 requested a review from a team June 27, 2024 16:38
germa89 added 2 commits June 27, 2024 18:39
@wiz-inc-572fc38784
Copy link
Copy Markdown
Contributor

wiz-inc-572fc38784 Bot commented Jun 27, 2024 •
edited
Loading

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 2I
Total 0C 0H 0M 0L 2I
Secrets 0🔑

@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Jun 27, 2024

NOT finished.

I need to fix the labels.

@germa89 germa89 added the DO NOT MERGE Not ready to be merged yet label Jun 27, 2024
@germa89 germa89 marked this pull request as draft June 27, 2024 16:42
auto-merge was automatically disabled June 27, 2024 16:42

Pull request was converted to draft

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (cda716a) to head (68cb8ef).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3228      +/-   ##
==========================================
- Coverage   82.64%   80.21%   -2.44%     
==========================================
  Files          53       53              
  Lines        9625     9625              
==========================================
- Hits         7955     7721     -234     
- Misses       1670     1904     +234

@germa89 germa89 requested a review from RobPasMue June 28, 2024 08:18
@germa89 germa89 marked this pull request as ready for review June 28, 2024 08:18
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 28, 2024
@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Jun 28, 2024

Ok. Now it is ready.

RobPasMue
RobPasMue reviewed Jun 28, 2024
View reviewed changes
Comment thread .github/labels.yml
PipKat
PipKat reviewed Jun 28, 2024
View reviewed changes
Comment thread .github/labels.yml Outdated
PipKat
PipKat reviewed Jun 28, 2024
View reviewed changes
Comment thread .github/labels.yml Outdated
PipKat
PipKat reviewed Jun 28, 2024
View reviewed changes
Comment thread doc/source/getting_started/develop_pymapdl.rst Outdated
PipKat
PipKat reviewed Jun 28, 2024
View reviewed changes
Comment thread doc/source/getting_started/develop_pymapdl.rst Outdated
PipKat
PipKat reviewed Jun 28, 2024
View reviewed changes
Comment thread doc/source/getting_started/develop_pymapdl.rst Outdated
PipKat
PipKat reviewed Jun 28, 2024
View reviewed changes
Comment thread doc/source/getting_started/develop_pymapdl.rst Outdated
PipKat
PipKat reviewed Jun 28, 2024
View reviewed changes
Comment thread doc/source/getting_started/develop_pymapdl.rst Outdated
PipKat
PipKat reviewed Jun 28, 2024
View reviewed changes
Comment thread doc/source/getting_started/develop_pymapdl.rst Outdated
PipKat
PipKat reviewed Jun 28, 2024
View reviewed changes
Comment thread doc/source/getting_started/develop_pymapdl.rst Outdated
PipKat
PipKat reviewed Jun 28, 2024
View reviewed changes
Comment thread doc/source/getting_started/develop_pymapdl.rst Outdated
PipKat
PipKat approved these changes Jun 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits--mostly to get rid of "etc."--as we want to avoid Latin phrases.

@germa89 germa89 removed the DO NOT MERGE Not ready to be merged yet label Jun 28, 2024
germa89 and others added 2 commits June 28, 2024 17:43
@germa89 @PipKat
Apply suggestions from code review
46463a5 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@germa89
fix: vale issue
9bb360f
@germa89 germa89 enabled auto-merge (squash) June 28, 2024 15:49
MaxJPRey
MaxJPRey approved these changes Jun 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Jul 1, 2024

many people approved it. Hence @pyansys-ci-bot LGTM.

jorgepiloto
jorgepiloto approved these changes Jul 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 disabled auto-merge July 1, 2024 06:26
@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Jul 1, 2024

I had to disable Require review from Code Owners because @jorgepiloto is not a code owner.

image

P.D.- @pyansys-ci-bot token has been replaced by a @jorgepiloto's one. Hence for this PR to be merged I had to disable the above requirement, since the workflow now is triggered with @jorgepiloto's credentials which is not a codeowner.

@germa89 germa89 merged commit c386f0c into main Jul 1, 2024
@germa89 germa89 deleted the docs/document-new-naming-conventions-for-commits,-branches-and-PRs branch July 1, 2024 07:07
@RobPasMue
Copy link
Copy Markdown
Member

RobPasMue commented Jul 1, 2024

Why not add him to the team temporarily?

@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Jul 1, 2024 •
edited
Loading

Codeowners require to edit the Codeowners file. I rather change not change files. :)

@RobPasMue
Copy link
Copy Markdown
Member

RobPasMue commented Jul 1, 2024 •
edited
Loading

No, you do not need to change the file - you just need to add @jorgepiloto to the @ansys/pymapdl-maintainers team.

pymapdl/.github/CODEOWNERS

Line 8 in a0028e6

* @ansys/pymapdl-maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@PipKat PipKat PipKat approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@Revathyvenugopal162 Revathyvenugopal162 Revathyvenugopal162 approved these changes

@SMoraisAnsys SMoraisAnsys SMoraisAnsys approved these changes

@clatapie clatapie Awaiting requested review from clatapie clatapie is a code owner automatically assigned from ansys/pymapdl-maintainers

@pyansys-ci-bot pyansys-ci-bot Awaiting requested review from pyansys-ci-bot pyansys-ci-bot is a code owner automatically assigned from ansys/pymapdl-maintainers

@klmcadams klmcadams Awaiting requested review from klmcadams

Assignees

@germa89 germa89

Labels

CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update documentation to changelog changes

8 participants

@germa89 @RobPasMue @jorgepiloto @PipKat @MaxJPRey @Revathyvenugopal162 @SMoraisAnsys @pyansys-ci-bot