Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jun 28, 2024

Description

The matrix for unit testing is getting very complicated.
I am going to off-load it to a shell file.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner June 28, 2024 09:26
@germa89 germa89 requested a review from clatapie June 28, 2024 09:26
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 28, 2024
@codecov
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.20%. Comparing base (587a0cb) to head (283916f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3232      +/-   ##
==========================================
- Coverage   82.67%   80.20%   -2.47%     
==========================================
  Files          53       53              
  Lines        9625     9625              
==========================================
- Hits         7957     7720     -237     
- Misses       1668     1905     +237     

@germa89
Copy link
Collaborator Author

germa89 commented Jun 28, 2024

References:

Stack Overflow
I have workflow that needs to have a loop for the steps, which is perfect with strategy/matrix.

The only problem is that strategy/matrix needs to be set by a constant.

Is it possible to use strat...

GitHub
Checks if someone is a member of an organization

@germa89 germa89 force-pushed the ci/using-array-job-for-setting-testing-matrix branch from 6aa6800 to ff4432c Compare June 28, 2024 16:43
@germa89 germa89 requested a review from a team June 28, 2024 16:45
@germa89 germa89 enabled auto-merge (squash) June 28, 2024 17:03
@germa89 germa89 self-assigned this Jun 28, 2024
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@germa89 germa89 merged commit e80e4ef into main Jul 8, 2024
@germa89 germa89 deleted the ci/using-array-job-for-setting-testing-matrix branch July 8, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants