Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 1, 2024

Description

Increase the files checked for changes before load docs cache.
Currently CICD does not check changes in the doc directory. This checks against it.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner July 1, 2024 07:25
@germa89 germa89 requested review from clatapie and removed request for a team July 1, 2024 07:25
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jul 1, 2024
@germa89 germa89 added CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) and removed documentation Documentation related (improving, adding, etc) labels Jul 1, 2024
@github-actions github-actions bot added the maintenance General maintenance of the repo (libraries, cicd, etc) label Jul 1, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Jul 1, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) July 1, 2024 07:33
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (cda716a) to head (d413d75).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
- Coverage   82.64%   80.21%   -2.44%     
==========================================
  Files          53       53              
  Lines        9625     9625              
==========================================
- Hits         7955     7721     -234     
- Misses       1670     1904     +234     

@germa89 germa89 merged commit a0028e6 into main Jul 1, 2024
@germa89 germa89 deleted the ci/checking-cache-changes-in-doc-builds branch July 1, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants