Skip to content

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Jul 9, 2024

Description

Recent changes on testing, make that some tests which where not tested before, are now tested.
The issue is a bit complex, because PyMAPDL leave some MAPDL instances loose, so I should make sure that mapdl.exit works properly.

Because other developers downstream needs ansys-api-mapdl 0.5.2, I'm going to do a patch release skipping these tests.

Issue linked

Related to #3254, #3257

Checklist

@germa89 germa89 requested a review from a team as a code owner July 9, 2024 16:30
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 9, 2024 16:30
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jul 9, 2024
@github-actions github-actions bot added the enhancement Improve any current implemented feature label Jul 9, 2024
@germa89 germa89 requested a review from koubaa July 9, 2024 16:31
@germa89 germa89 enabled auto-merge (squash) July 9, 2024 16:34
@codecov
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.61%. Comparing base (d4fe3a1) to head (207f858).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3259   +/-   ##
=======================================
  Coverage   86.61%   86.61%           
=======================================
  Files          53       53           
  Lines        9630     9630           
=======================================
  Hits         8341     8341           
  Misses       1289     1289           

@germa89 germa89 merged commit 9047d71 into main Jul 9, 2024
@germa89 germa89 deleted the fix/skip-tests-until-fix-them branch July 9, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants