Skip to content

feat: database module improvements#3320

Merged
germa89 merged 13 commits intomainfrom
feat/database-module-improvements
Aug 27, 2024
Merged

feat: database module improvements#3320
germa89 merged 13 commits intomainfrom
feat/database-module-improvements

Conversation

@germa89
Copy link
Copy Markdown
Collaborator

@germa89 germa89 commented Jul 31, 2024

Description

  • Fixing database not using the specified port.
  • Removing the context manager for Begin level, and use the standard run_as_routine context manager.
  • Relaxing the routines names.
  • Refactoring a bit.

Small database module improvements I'm doing while I try to fix the issue #3248

Issue linked

Related #3248

Checklist

@germa89 germa89 requested a review from a team as a code owner July 31, 2024 10:30
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team July 31, 2024 10:30
@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Jul 31, 2024
@germa89 germa89 self-assigned this Aug 5, 2024
@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Aug 20, 2024

Pinging @clatapie for feedback and review.

@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Aug 27, 2024

@pyansys-ci-bot LGTM.

Copy link
Copy Markdown
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 enabled auto-merge (squash) August 27, 2024 15:43
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 84.31373% with 8 lines in your changes missing coverage. Please review.

Project coverage is 86.21%. Comparing base (93dd176) to head (933d4e7).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3320      +/-   ##
==========================================
- Coverage   87.13%   86.21%   -0.92%     
==========================================
  Files          55       55              
  Lines        9816    11273    +1457     
==========================================
+ Hits         8553     9719    +1166     
- Misses       1263     1554     +291     

@germa89 germa89 merged commit eabf4ca into main Aug 27, 2024
@germa89 germa89 deleted the feat/database-module-improvements branch August 27, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants