Skip to content

feat: adding channel subscription method and tests#3340

Merged
germa89 merged 5 commits into
mainfrom
feat/adding-channel-subscription
Aug 9, 2024
Merged

feat: adding channel subscription method and tests#3340
germa89 merged 5 commits into
mainfrom
feat/adding-channel-subscription

Conversation

@germa89
Copy link
Copy Markdown
Collaborator

@germa89 germa89 commented Aug 8, 2024

Description

Adding a method to retrieve the gRPC channel status through channel subscription.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner August 8, 2024 18:16
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team August 8, 2024 18:16
@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Aug 8, 2024
@github-actions github-actions Bot added the new feature Request or proposal for a new feature label Aug 8, 2024
@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Aug 8, 2024

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.12%. Comparing base (a8b1514) to head (a51a318).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3340      +/-   ##
==========================================
- Coverage   87.13%   87.12%   -0.02%     
==========================================
  Files          55       55              
  Lines        9773     9810      +37     
==========================================
+ Hits         8516     8547      +31     
- Misses       1257     1263       +6     

@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Aug 9, 2024

@pyansys-ci-bot LGTM.

Copy link
Copy Markdown
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 6b6b797 into main Aug 9, 2024
@germa89 germa89 deleted the feat/adding-channel-subscription branch August 9, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants