docs: review of documenting using pymapdl on clusters (#3466)#3506
Merged
docs: review of documenting using pymapdl on clusters (#3466)#3506
Conversation
* feat: adding env vars needed for multinode * feat: adding env vars needed for multinode * feat: renaming hpc detection argument * docs: adding documentation * chore: adding changelog file 3466.documentation.md * feat: adding env vars needed for multinode * feat: renaming hpc detection argument * docs: adding documentation * chore: adding changelog file 3466.documentation.md * fix: vale issues * chore: To fix sphinx build Squashed commit of the following: commit c1d1a3e Author: German <28149841+germa89@users.noreply.github.com> Date: Mon Oct 7 15:33:19 2024 +0200 ci: retrigger CICD commit b7b5c30 Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon Oct 7 13:31:55 2024 +0000 ci: auto fixes from pre-commit.com hooks. for more information, see https://pre-commit.ci commit 32a1c02 Author: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com> Date: Mon Oct 7 15:31:24 2024 +0200 fix: add suggestions Co-authored-by: German <28149841+germa89@users.noreply.github.com> commit 575a219 Merge: f2afe13 be1be2e Author: Revathyvenugopal162 <revathy.venugopal@ansys.com> Date: Mon Oct 7 15:09:01 2024 +0200 Merge branch 'fix/add-build-cheatsheet-as-env-varaible' of https://github.com/ansys/pymapdl into fix/add-build-cheatsheet-as-env-varaible commit f2afe13 Author: Revathyvenugopal162 <revathy.venugopal@ansys.com> Date: Mon Oct 7 15:08:58 2024 +0200 fix: precommit commit be1be2e Author: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Mon Oct 7 13:07:35 2024 +0000 chore: adding changelog file 3468.fixed.md commit f052a4d Author: Revathyvenugopal162 <revathy.venugopal@ansys.com> Date: Mon Oct 7 15:05:56 2024 +0200 fix: add build cheatsheet as env variable within doc-build * docs: expanding a bit troubleshooting advices and small format fix * docs: fix vale * fix: nproc tests * feat: adding env vars needed for multinode * feat: renaming hpc detection argument * docs: adding documentation * chore: adding changelog file 3466.documentation.md * fix: vale issues * docs: fix vale * docs: expanding a bit troubleshooting advices and small format fix * fix: nproc tests * revert: "chore: To fix sphinx build" This reverts commit e45d2e5. * docs: clarifying where everything is running. * docs: expanding bash example * tests: fix * docs: adding `PYMAPDL_NPROC` to env var section * docs: fix vale issue * docs: fix vale issue * fix: replacing env var name * fix: unit tests * chore: adding changelog file 3466.documentation.md [dependabot-skip] * Apply suggestions from code review Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com> * docs: apply suggestions from code review made by Kathy Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com> * docs: adding Kathy suggestion. --------- Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com> Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Collaborator
Author
|
Surprisingly I got so many issues........ |
germa89
commented
Oct 23, 2024
Collaborator
Author
|
Since this is just the doc review from @PipKat made in #3466 . I does not need approval. Hence: @pyansys-ci-bot LGTM |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3506 +/- ##
==========================================
- Coverage 82.33% 82.31% -0.02%
==========================================
Files 57 57
Lines 10007 10004 -3
==========================================
- Hits 8239 8235 -4
- Misses 1768 1769 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR is just bringing the changes made in #3466 into main.
Branching
I was waiting for a doc review for #3466. This PR aimed to merge
feat/passing-tight-integration-env-vars-to-MAPDLintomain.Because I was needing these changes in
mainbut I didn't want to merge those without @PipKat approval, I did a copy of both branches....feat/copy-passing-tight-integration-env-vars-to-MAPDLforfeat/passing-tight-integration-env-vars-to-MAPDLmaint/main_copyformain.Then I changed the target of #3466 to be
maint/main_copy.Then I opened another PR (#3500) which aimed to merge the copy
feat/copy-passing-tight-integration-env-vars-to-MAPDLintomain. And I merged.Then I kept #3466 untouched (well, I did change the PR name to reflect the new content basically doc review). This way, the changes done (File tab in the PR) were considered still with respect to the
mainwithout #3500 which contained everything but @PipKat corrections.Commit history
feat: adding env vars needed for multinode
feat: adding env vars needed for multinode
feat: renaming hpc detection argument
docs: adding documentation
chore: adding changelog file 3466.documentation.md
feat: adding env vars needed for multinode
feat: renaming hpc detection argument
docs: adding documentation
chore: adding changelog file 3466.documentation.md
fix: vale issues
chore: To fix sphinx build
Squashed commit of the following:
commit c1d1a3e
Author: German 28149841+germa89@users.noreply.github.com
Date: Mon Oct 7 15:33:19 2024 +0200
commit b7b5c30
Author: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Date: Mon Oct 7 13:31:55 2024 +0000
commit 32a1c02
Author: Revathy Venugopal 104772255+Revathyvenugopal162@users.noreply.github.com
Date: Mon Oct 7 15:31:24 2024 +0200
commit 575a219
Merge: f2afe13 be1be2e
Author: Revathyvenugopal162 revathy.venugopal@ansys.com
Date: Mon Oct 7 15:09:01 2024 +0200
commit f2afe13
Author: Revathyvenugopal162 revathy.venugopal@ansys.com
Date: Mon Oct 7 15:08:58 2024 +0200
commit be1be2e
Author: pyansys-ci-bot 92810346+pyansys-ci-bot@users.noreply.github.com
Date: Mon Oct 7 13:07:35 2024 +0000
commit f052a4d
Author: Revathyvenugopal162 revathy.venugopal@ansys.com
Date: Mon Oct 7 15:05:56 2024 +0200
docs: expanding a bit troubleshooting advices and small format fix
docs: fix vale
fix: nproc tests
feat: adding env vars needed for multinode
feat: renaming hpc detection argument
docs: adding documentation
chore: adding changelog file 3466.documentation.md
fix: vale issues
docs: fix vale
docs: expanding a bit troubleshooting advices and small format fix
fix: nproc tests
revert: "chore: To fix sphinx build"
This reverts commit e45d2e5.
docs: clarifying where everything is running.
docs: expanding bash example
tests: fix
docs: adding
PYMAPDL_NPROCto env var sectiondocs: fix vale issue
docs: fix vale issue
fix: replacing env var name
fix: unit tests
chore: adding changelog file 3466.documentation.md [dependabot-skip]
Apply suggestions from code review
Co-authored-by: Camille 78221213+clatapie@users.noreply.github.com
Co-authored-by: Kathy Pippert 84872299+PipKat@users.noreply.github.com
Co-authored-by: pyansys-ci-bot 92810346+pyansys-ci-bot@users.noreply.github.com
Co-authored-by: Camille 78221213+clatapie@users.noreply.github.com
Co-authored-by: Kathy Pippert 84872299+PipKat@users.noreply.github.com
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)