Skip to content

feat: using version instead of exec_path for the MPI checks#3528

Merged
germa89 merged 2 commits intomainfrom
fix/windows-launching-because-of-quotes
Oct 30, 2024
Merged

feat: using version instead of exec_path for the MPI checks#3528
germa89 merged 2 commits intomainfrom
fix/windows-launching-because-of-quotes

Conversation

@germa89
Copy link
Copy Markdown
Collaborator

@germa89 germa89 commented Oct 30, 2024

Description

As the title.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner October 30, 2024 17:29
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team October 30, 2024 17:29
@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Oct 30, 2024
@github-actions github-actions bot added the new feature Request or proposal for a new feature label Oct 30, 2024
@germa89 germa89 enabled auto-merge (squash) October 30, 2024 17:30
@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Oct 30, 2024

@pyansys-ci-bot LGTM.

Copy link
Copy Markdown
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (c151d73) to head (fe2550b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3528      +/-   ##
==========================================
- Coverage   87.48%   87.43%   -0.05%     
==========================================
  Files          58       58              
  Lines       10214    10214              
==========================================
- Hits         8936     8931       -5     
- Misses       1278     1283       +5     

@germa89 germa89 merged commit de6813f into main Oct 30, 2024
@germa89 germa89 deleted the fix/windows-launching-because-of-quotes branch October 30, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants