Skip to content

refactor: adding logging calls to misc.py - #3550

Merged
germa89 merged 3 commits into
mainfrom
feat/adding-logging-to-misc
Nov 18, 2024
Merged

refactor: adding logging calls to misc.py#3550
germa89 merged 3 commits into
mainfrom
feat/adding-logging-to-misc

Conversation

@germa89

@germa89 germa89 commented Nov 18, 2024

Copy link
Copy Markdown
Collaborator

Description

Adding logging to misc module.

Issue linked

Close #3489

Checklist

@germa89
germa89 requested a review from a team as a code owner November 18, 2024 09:56
@germa89
germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 18, 2024 09:56
@germa89 germa89 self-assigned this Nov 18, 2024
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89
germa89 enabled auto-merge (squash) November 18, 2024 09:56
@germa89

germa89 commented Nov 18, 2024

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@github-actions github-actions Bot added the enhancement Improve any current implemented feature label Nov 18, 2024

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov

codecov Bot commented Nov 18, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (7f64156) to head (a7ed61d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3550      +/-   ##
==========================================
- Coverage   91.32%   91.27%   -0.05%     
==========================================
  Files         187      187              
  Lines       14640    14644       +4     
==========================================
- Hits        13370    13367       -3     
- Misses       1270     1277       +7     

@germa89
germa89 merged commit 06397a3 into main Nov 18, 2024
@germa89
germa89 deleted the feat/adding-logging-to-misc branch November 18, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

misc module is lacking logging

2 participants