Skip to content

feat: raising error if plot image cannot be obtained#3559

Merged
germa89 merged 6 commits intomainfrom
feat/avoid-empty-file-on-non-vtk-plots
Nov 21, 2024
Merged

feat: raising error if plot image cannot be obtained#3559
germa89 merged 6 commits intomainfrom
feat/avoid-empty-file-on-non-vtk-plots

Conversation

@germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 20, 2024

Description

As the title.

mapdl.screenshot does not get affected.

Issue linked

NA but related with some tests done #3519

Checklist

@germa89 germa89 requested a review from a team as a code owner November 20, 2024 10:21
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 20, 2024 10:21
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the new feature Request or proposal for a new feature label Nov 20, 2024
@codecov
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.61%. Comparing base (dff1bab) to head (b834121).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3559      +/-   ##
==========================================
+ Coverage   86.60%   86.61%   +0.01%     
==========================================
  Files         187      187              
  Lines       14638    14639       +1     
==========================================
+ Hits        12677    12680       +3     
+ Misses       1961     1959       -2     
---- 🚨 Try these New Features:

@germa89 germa89 self-assigned this Nov 21, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Nov 21, 2024

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) November 21, 2024 18:47
Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 9cdcaaa into main Nov 21, 2024
@germa89 germa89 deleted the feat/avoid-empty-file-on-non-vtk-plots branch November 21, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants