Skip to content

refactor: annotate pymapdl part 1#3569

Merged
germa89 merged 39 commits into
mainfrom
refactor/annotate-files
Dec 18, 2024
Merged

refactor: annotate pymapdl part 1#3569
germa89 merged 39 commits into
mainfrom
refactor/annotate-files

Conversation

@germa89

@germa89 germa89 commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

Description

Annotate some files

Issue linked

Related to #3480

Checklist

@germa89 germa89 requested a review from a team as a code owner November 22, 2024 12:41
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 22, 2024 12:41
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Nov 22, 2024
@github-actions github-actions Bot added the enhancement Improve any current implemented feature label Nov 22, 2024
@germa89 germa89 mentioned this pull request Nov 22, 2024
@germa89

germa89 commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator Author

@ansys-reviewer-bot review

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Okay, I will trigger a review of your PR.

@clatapie clatapie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread src/ansys/mapdl/core/cli/stop.py Outdated
Co-authored-by: Camille <78221213+clatapie@users.noreply.github.com>
@germa89

germa89 commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator Author

Okay, I will trigger a review of your PR.

... so?

@RobPasMue

@RobPasMue

Copy link
Copy Markdown
Member

@ansys-reviewer-bot review

@codecov

codecov Bot commented Nov 25, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 99.65035% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.15%. Comparing base (b5e482a) to head (d3a7188).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3569      +/-   ##
==========================================
+ Coverage   87.01%   87.15%   +0.14%     
==========================================
  Files         187      187              
  Lines       14661    14660       -1     
==========================================
+ Hits        12757    12777      +20     
+ Misses       1904     1883      -21     

) # match number groups
BC_REGREP = re.compile(r"^\s*([0-9]+)\s*([A-Za-z]+)((?:\s+[0-9]*[.]?[0-9]+)+)$")
BC_REGREP: re.Pattern = re.compile(
r"^\s*([0-9]+)\s*([A-Za-z]+)((?:\s+[0-9]*[.]?[0-9]+)+)$"

Check failure

Code scanning / CodeQL

Inefficient regular expression

This part of the regular expression may cause exponential backtracking on strings starting with '0A ' and containing many repetitions of '00 '.
@germa89

germa89 commented Dec 13, 2024

Copy link
Copy Markdown
Collaborator Author

@RobPasMue any news about the bot?

@germa89

germa89 commented Dec 13, 2024

Copy link
Copy Markdown
Collaborator Author

@ansys-reviewer-bot review

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Okay, I will trigger a review of your PR.

@RobPasMue

Copy link
Copy Markdown
Member

@RobPasMue any news about the bot?

Nope - too many parallel tracks currently

@germa89

germa89 commented Dec 16, 2024

Copy link
Copy Markdown
Collaborator Author

@RobPasMue any news about the bot?

Nope - too many parallel tracks currently

Roger that... you tell me... this PR is no priority and if you think it is a good test for the bot (since it is just annotating... no other logic)... I can keep it open... or go ahead... up to you.

@RobPasMue

Copy link
Copy Markdown
Member

Go ahead... don't wait for me. Sorry @germa89

@germa89

germa89 commented Dec 16, 2024

Copy link
Copy Markdown
Collaborator Author

Go ahead... don't wait for me. Sorry @germa89

No big deal at all! :)

@germa89 germa89 enabled auto-merge (squash) December 18, 2024 10:13
@germa89 germa89 merged commit 06c93c0 into main Dec 18, 2024
@germa89 germa89 deleted the refactor/annotate-files branch December 18, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DO NOT MERGE Not ready to be merged yet enhancement Improve any current implemented feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants