Skip to content

feat: adding check_has_mapdl - #3576

Merged
germa89 merged 6 commits into
mainfrom
feat/adding-check_has_mapdl
Nov 26, 2024
Merged

feat: adding check_has_mapdl#3576
germa89 merged 6 commits into
mainfrom
feat/adding-check_has_mapdl

Conversation

@germa89

@germa89 germa89 commented Nov 25, 2024

Copy link
Copy Markdown
Collaborator

Description

Adding check_has_mapdl function.

Issue linked

NA

Checklist

@germa89
germa89 requested a review from a team as a code owner November 25, 2024 20:21
@germa89
germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team November 25, 2024 20:21
@germa89 germa89 self-assigned this Nov 25, 2024
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89

germa89 commented Nov 25, 2024

Copy link
Copy Markdown
Collaborator Author

To merge before #3573

@github-actions github-actions Bot added the new feature Request or proposal for a new feature label Nov 25, 2024
@germa89

germa89 commented Nov 25, 2024

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov

codecov Bot commented Nov 25, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.98%. Comparing base (853daba) to head (5b0e3b3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3576      +/-   ##
==========================================
+ Coverage   86.93%   86.98%   +0.04%     
==========================================
  Files         187      187              
  Lines       14616    14623       +7     
==========================================
+ Hits        12707    12720      +13     
+ Misses       1909     1903       -6     

@germa89

germa89 commented Nov 26, 2024

Copy link
Copy Markdown
Collaborator Author

Since we merged #3268 the tests take way longer...

@germa89
germa89 merged commit 76d8ee7 into main Nov 26, 2024
@germa89
germa89 deleted the feat/adding-check_has_mapdl branch November 26, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants