Skip to content

feat: avoid errors when retrieving invalid routine#3606

Merged
germa89 merged 8 commits intomainfrom
fix/avoid-error-when-retriving-routine
Dec 13, 2024
Merged

feat: avoid errors when retrieving invalid routine#3606
germa89 merged 8 commits intomainfrom
fix/avoid-error-when-retriving-routine

Conversation

@germa89
Copy link
Copy Markdown
Collaborator

@germa89 germa89 commented Dec 9, 2024

Description

As the title. Sometimes, MAPDL retrieves back a wrong routine number. We should not raise an exception, and just finish the current routine.

Issue linked

NA

Checklist

@germa89 germa89 requested a review from a team as a code owner December 9, 2024 13:18
@germa89 germa89 requested review from clatapie and pyansys-ci-bot and removed request for a team December 9, 2024 13:18
@ansys-reviewer-bot
Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Dec 9, 2024
@github-actions github-actions Bot added the new feature Request or proposal for a new feature label Dec 9, 2024
@germa89 germa89 changed the title feat: avoid errors when retriving invalid routine feat: avoid errors when retrieving invalid routine Dec 9, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (27c6ec9) to head (7957545).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3606   +/-   ##
=======================================
  Coverage   86.99%   86.99%           
=======================================
  Files         187      187           
  Lines       14628    14632    +4     
=======================================
+ Hits        12725    12729    +4     
  Misses       1903     1903           

@germa89
Copy link
Copy Markdown
Collaborator Author

germa89 commented Dec 11, 2024

@pyansys-ci-bot LGTM.

Copy link
Copy Markdown
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 3c81f2d into main Dec 13, 2024
@germa89 germa89 deleted the fix/avoid-error-when-retriving-routine branch December 13, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants