fix: avoid MAPDL commands execution when gRPC connection fails.#3686
Merged
germa89 merged 14 commits intoJan 23, 2025
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
…ing-more-mapdl-calls-when-the-gRPC-connection-failed
Collaborator
Author
|
Profiler info: InsightsOptimize Hooks in pytest:Investigate why pluggy hooks are being called so frequently. Consider reducing the number of hooks or optimizing hook implementations. Analyze Locking Overhead:The high time spent in _thread.lock.acquire suggests contention or excessive synchronization. Profiling thread usage in ansys.mapdl or other parts of the code could identify improvements. Improve ansys.mapdl Functions:Functions like wrapper and inner_wrapper should be examined for overhead. Profiling within these functions might reveal inefficient logic or excessive I/O calls. Investigate gRPC Communication:High cumulative time in gRPC functions suggests delays in message handling or transport. Review the communication patterns, message sizes, and server-client interactions. Focus on High Cumulative Time:Target the functions with the highest cumtime (pytest_runtest_protocol, wrapper, inner_wrapper) for optimization, as they are the biggest contributors to runtime. |
Collaborator
Author
|
Checking the profiler, it seems that a lot of time is spent on wrapping the XSEL commands: 
which basically seems to come from pymapdl/src/ansys/mapdl/core/mapdl_core.py Lines 1449 to 1462 in 8be236d I need to improve this mess... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3686 +/- ##
==========================================
- Coverage 87.14% 87.08% -0.07%
==========================================
Files 187 187
Lines 14697 14698 +1
==========================================
- Hits 12808 12800 -8
- Misses 1889 1898 +9 |
Collaborator
Author
ReasonIt seems we are executing ErrorError code
From: https://github.com/ansys/pymapdl/actions/runs/12907800033/job/35992191911?pr=3686#step:11:197 |
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
germa89
deleted the
fix/avoid-issuing-more-mapdl-calls-when-the-gRPC-connection-failed
branch
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Making sure we avoid executing more commands when exiting MAPDL.
Issue linked
Close #3685
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)