Skip to content

feat: avoiding reconnecting if MAPDL exited already - #3708

Merged
germa89 merged 30 commits into
mainfrom
feat/avoiding-reconnecting-if-MAPDL-exited-already
Jan 27, 2025
Merged

germa89 merged 30 commits into
mainfrom
feat/avoiding-reconnecting-if-MAPDL-exited-already

Conversation

@germa89

@germa89 germa89 commented Jan 27, 2025 •

Copy link
Copy Markdown
Collaborator

Description

As the title.

Issue linked

Close #3707

Checklist

germa89 and others added 27 commits January 24, 2025 12:13
Performance is not as go

This reverts commit 877f803.
Performance is not as go

This reverts commit 877f803.
@germa89
germa89 requested a review from a team as a code owner January 27, 2025 14:41
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jan 27, 2025
@github-actions github-actions Bot added the new feature Request or proposal for a new feature label Jan 27, 2025
@codecov

codecov Bot commented Jan 27, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (a2f91e6) to head (b1a9eaa).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3708      +/-   ##
==========================================
+ Coverage   87.88%   88.07%   +0.18%     
==========================================
  Files         187      187              
  Lines       14710    14703       -7     
==========================================
+ Hits        12928    12949      +21     
+ Misses       1782     1754      -28     

@germa89

germa89 commented Jan 27, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
germa89 merged commit 521ee2f into main Jan 27, 2025
@germa89
germa89 deleted the feat/avoiding-reconnecting-if-MAPDL-exited-already branch January 27, 2025 17:27
germa89 added a commit that referenced this pull request Feb 14, 2025
* test: refactor check_stds and post_mortem_checks

* test: backing off algorithm

* chore: adding changelog file 3703.added.md [dependabot-skip]

* fix: codacity warnings

* feat: using get_value to obtain the n elements

* revert: revert "feat: using get_value to obtain the n elements"
Performance is not as go

This reverts commit 877f803.

* feat: using get_value to obtain the n elements

* revert: revert "feat: using get_value to obtain the n elements"
Performance is not as go

This reverts commit 877f803.

* feat: using mapdl.exit when raising final error.

* test: fix test by avoiding killing mapdl.

* fix: test

* fix: test

* feat: adding warnings when restarting MAPDL during testing

* fix: test

* feat: caching requires_package

* test: adding more tests

* chore: adding changelog file 3705.added.md [dependabot-skip]

* chore: adding changelog file 3705.added.md [dependabot-skip]

* fix: warnings import

* feat: not reconnecting if MAPDL already exited

* test: adding tests

* chore: adding changelog file 3708.miscellaneous.md [dependabot-skip]

* fix: tests

---------

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests teardown is very slow

2 participants