Skip to content

ci: improving testing#3716

Merged
germa89 merged 30 commits into
mainfrom
ci/testing-improvements
Feb 14, 2025
Merged

ci: improving testing#3716
germa89 merged 30 commits into
mainfrom
ci/testing-improvements

Conversation

@germa89

@germa89 germa89 commented Jan 29, 2025

Copy link
Copy Markdown
Collaborator

Description

As the title.

Issue linked

Related to #3714

Checklist

@germa89 germa89 requested a review from a team as a code owner January 29, 2025 14:23
@germa89 germa89 self-assigned this Jan 29, 2025
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the CI/CD Related with CICD, Github Actions, etc label Jan 29, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Jan 29, 2025
@github-actions github-actions Bot added dependencies maintenance General maintenance of the repo (libraries, cicd, etc) CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Jan 29, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Jan 29, 2025
@codecov

codecov Bot commented Jan 29, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.24%. Comparing base (dce90bd) to head (3e0acfb).
Report is 4 commits behind head on main.

❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3716      +/-   ##
==========================================
- Coverage   88.25%   88.24%   -0.02%     
==========================================
  Files         187      187              
  Lines       14701    14705       +4     
==========================================
+ Hits        12975    12977       +2     
- Misses       1726     1728       +2     

@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 10, 2025
Comment thread pyproject.toml Outdated
Comment thread src/ansys/mapdl/core/mapdl_core.py Outdated
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 10, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 10, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 13, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 13, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 13, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 13, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 14, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 14, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 14, 2025
@germa89

germa89 commented Feb 14, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

Comment thread pyproject.toml Outdated
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc and removed CI/CD Related with CICD, Github Actions, etc labels Feb 14, 2025
@germa89 germa89 merged commit b39d487 into main Feb 14, 2025
@germa89 germa89 deleted the ci/testing-improvements branch February 14, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc dependencies maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants