Skip to content

fix: exiting on class deletion - #3738

Merged
germa89 merged 9 commits into
mainfrom
fix/exiting
Feb 13, 2025
Merged

fix: exiting on class deletion#3738
germa89 merged 9 commits into
mainfrom
fix/exiting

Conversation

@germa89

@germa89 germa89 commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

Description

Kills MAPDL on object deletion if the instance was launched by that instance.

Issue linked

Close #3692
Close #3394
Close #3514

Checklist

@germa89
germa89 requested a review from a team as a code owner February 12, 2025 18:59
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Feb 12, 2025
@github-actions github-actions Bot added the bug Issue, problem or error in PyMAPDL label Feb 12, 2025
@codecov

codecov Bot commented Feb 12, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.26%. Comparing base (fd951d1) to head (3fd654d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3738      +/-   ##
==========================================
+ Coverage   88.07%   88.26%   +0.19%     
==========================================
  Files         187      187              
  Lines       14717    14701      -16     
==========================================
+ Hits        12962    12976      +14     
+ Misses       1755     1725      -30     

@germa89

germa89 commented Feb 13, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
germa89 merged commit dce90bd into main Feb 13, 2025
@germa89
germa89 deleted the fix/exiting branch February 13, 2025 12:40
germa89 added a commit that referenced this pull request Feb 14, 2025
* test: __del__method.

* refactor: simplifying exit

* chore: adding changelog file 3738.fixed.md [dependabot-skip]

* refactor: simplyfing for other interfaces.

* feat: exiting mapdl

* feat: adding __del__ to mapdl_console

* fix: improve job ID handling and remove atexit registration in MAPDL core

---------

Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Garbage collector does not kill MAPDL mapdl.exit can be slow Add server exit to python del mapdl

2 participants