Skip to content

fix: Bug located in VSEL using KSWP field#3753

Merged
kmkoshy merged 2 commits into
mainfrom
fix-Bug-located-in-VSEL-using-KSWP-field
Feb 19, 2025
Merged

fix: Bug located in VSEL using KSWP field#3753
kmkoshy merged 2 commits into
mainfrom
fix-Bug-located-in-VSEL-using-KSWP-field

Conversation

@kmkoshy

@kmkoshy kmkoshy commented Feb 19, 2025

Copy link
Copy Markdown
Contributor

Description

Please provide a brief description of the changes made in this pull request.
Fix for #3349

  1. ksel, esel, nsel uses kabs (for field 7)
  2. lsel, asel, vsel uses kswp (for field 7)

Wrappers on vsel and other related cmds - like @allow_pickable_entities use _get_args_xsel to get the args passed. This function currently accounts only for kabs , added logic for kswp.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.
#3349

Checklist

@kmkoshy
kmkoshy requested a review from a team as a code owner February 19, 2025 07:00
@kmkoshy
kmkoshy requested review from clatapie and germa89 February 19, 2025 07:00
@kmkoshy kmkoshy linked an issue Feb 19, 2025 that may be closed by this pull request
4 tasks
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@kmkoshy kmkoshy self-assigned this Feb 19, 2025
@github-actions github-actions Bot added the bug Issue, problem or error in PyMAPDL label Feb 19, 2025
@codecov

codecov Bot commented Feb 19, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.33%. Comparing base (62b3786) to head (833827a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3753      +/-   ##
==========================================
+ Coverage   88.28%   88.33%   +0.04%     
==========================================
  Files         187      187              
  Lines       14704    14704              
==========================================
+ Hits        12982    12989       +7     
+ Misses       1722     1715       -7     

@germa89 germa89 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution @kmkoshy! Thank you for fixing this!

@kmkoshy
kmkoshy merged commit 4c6e65a into main Feb 19, 2025
@kmkoshy
kmkoshy deleted the fix-Bug-located-in-VSEL-using-KSWP-field branch February 19, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in VSEL using KSWP field.

3 participants