ci: use ubuntu-latest github image - #3814
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
|
This might requires more changes on the container, which will come with the new Thank you @SMoraisAnsys :) |
|
@SMoraisAnsys so it seems to me I just need to update the It is probably more convenient to just update the docker image to run Ubuntu 24.04 I guess, instead of recompiling GLIB in 20.04. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3814 +/- ##
==========================================
- Coverage 91.85% 91.80% -0.06%
==========================================
Files 187 187
Lines 15033 15033
==========================================
- Hits 13809 13801 -8
- Misses 1224 1232 +8 🚀 New features to boost your workflow:
|
|
@SMoraisAnsys can I get some clarification on why |
|
@SMoraisAnsys ... why now everything is passing? wtf.... |
|
@SMoraisAnsys If the CICD pass, I see no reason to not merge. @pyansys-ci-bot LGTM |
|
Sry @germa89 didnt have a look here in quite a while. I'll do that when I've got time. If I remember correctly, the issue was coming from setup-python action |
The reason for that change is that this package is no longer available in ubuntu 24.04.
|
Seems like the |
|
@SMoraisAnsys failing again... I guess a previous merge from main deleted your changes? Until I restored them in 257a8e7 Only the local tests fail.... I guess I am going to be forced to update to Ubuntu 24:04 ... |
|
Since this requires changes on the container, and I opened already an issue for that, I'm closing this PR. I will reopen it in the future. https://github.com/ansys-internal/mapdl-docker-image-builder/issues/155 |
… into ci/use-ubuntu-latest
SummaryEvery workflow has been updated to Only solution seems to be keep using |
|
@SMoraisAnsys can I have a verbal approval for this PR? |
Yup, all fine. Glad this can be updated. Note that you might want to notify @klmcadams as I remember she seems to be following the same image as you in another repo. |
True. However, I believe she is running inside the container (local) so she must not be able to apply this change until I upgrade the container... eventually I will find the time. |
|
@SMoraisAnsys @germa89 We pinned ubuntu-22.04 in also pinging @AlejandroFernandezLuces in case the new repo had to do something similar for the workflow? |

Description
It seems that the reason the ubuntu image is pinned down to
22.04is related to a lib that is no longer available in24.04(current latest). Just checking if those changes could fix this and if you want to use a newer version of the ubuntu github image :)Also I removed lib duplicates in the a devcontainer's Dockerfile.
Note
There is still an issue related to the
glibcversion. This is already associated to an issue where maintainers fromsetup-pythonhave answer and I'm adding a link to the section below for traceability :)Issue linked
Related to #3659
Related to ansys/ansys-tools-path#268
Related to actions/setup-python#1053
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)