Skip to content

ci: use ubuntu-latest github image - #3814

Merged
germa89 merged 15 commits into
mainfrom
ci/use-ubuntu-latest
Jul 10, 2025
Merged

ci: use ubuntu-latest github image#3814
germa89 merged 15 commits into
mainfrom
ci/use-ubuntu-latest

Conversation

@SMoraisAnsys

@SMoraisAnsys SMoraisAnsys commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

Description

It seems that the reason the ubuntu image is pinned down to 22.04 is related to a lib that is no longer available in 24.04 (current latest). Just checking if those changes could fix this and if you want to use a newer version of the ubuntu github image :)

Also I removed lib duplicates in the a devcontainer's Dockerfile.

Note

There is still an issue related to the glibc version. This is already associated to an issue where maintainers from setup-python have answer and I'm adding a link to the section below for traceability :)

Issue linked

Related to #3659
Related to ansys/ansys-tools-path#268
Related to actions/setup-python#1053

Checklist

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@wiz-inc-572fc38784

wiz-inc-572fc38784 Bot commented Mar 27, 2025

Copy link
Copy Markdown
Contributor

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations 2 Medium
Total 2 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Mar 27, 2025
@germa89

germa89 commented Mar 27, 2025

Copy link
Copy Markdown
Collaborator

This might requires more changes on the container, which will come with the new CICD flavour. I will keep an eye on this.

Thank you @SMoraisAnsys :)

@germa89

germa89 commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator

@SMoraisAnsys so it seems to me I just need to update the GCLIB to at least to 2.39 in order to get rid of this issue.

It is probably more convenient to just update the docker image to run Ubuntu 24.04 I guess, instead of recompiling GLIB in 20.04.

@codecov

codecov Bot commented Apr 1, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (cb35c0c) to head (077f904).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3814      +/-   ##
==========================================
- Coverage   91.85%   91.80%   -0.06%     
==========================================
  Files         187      187              
  Lines       15033    15033              
==========================================
- Hits        13809    13801       -8     
- Misses       1224     1232       +8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89

germa89 commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

@SMoraisAnsys can I get some clarification on why ibglx-mesa0 instead of libgl1-mesa-glx ?? Because very likely I am going to port that change to the container builder repo.

@germa89

germa89 commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator

@SMoraisAnsys ... why now everything is passing? wtf....

@germa89

germa89 commented Apr 11, 2025

Copy link
Copy Markdown
Collaborator

@SMoraisAnsys If the CICD pass, I see no reason to not merge.

@pyansys-ci-bot LGTM

@germa89
germa89 marked this pull request as ready for review April 11, 2025 17:56
@germa89
germa89 requested a review from a team as a code owner April 11, 2025 17:56
@germa89
germa89 requested review from clatapie and germa89 April 11, 2025 17:56

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@SMoraisAnsys

Copy link
Copy Markdown
Contributor Author

Sry @germa89 didnt have a look here in quite a while. I'll do that when I've got time. If I remember correctly, the issue was coming from setup-python action

@SMoraisAnsys

SMoraisAnsys commented Apr 12, 2025

Copy link
Copy Markdown
Contributor Author

@SMoraisAnsys can I get some clarification on why ibglx-mesa0 instead of libgl1-mesa-glx ?? Because very likely I am going to port that change to the container builder repo.

The reason for that change is that this package is no longer available in ubuntu 24.04.
It seems that the mesa developers have split out the FLX backend into a separate library. See https://askubuntu.com/a/1520333

Ask Ubuntu
I'm trying to install libgl1-mesa-glx since I need it to run packettracer. fabio@fabio-MS-7750:~/packettracer$ sudo apt-get install libgl1-mesa-glx Reading package lists... Done Building dependency...

@SMoraisAnsys

Copy link
Copy Markdown
Contributor Author

@SMoraisAnsys so it seems to me I just need to update the GCLIB to at least to 2.39 in order to get rid of this issue.

It is probably more convenient to just update the docker image to run Ubuntu 24.04 I guess, instead of recompiling GLIB in 20.04.

Seems like the glibc of the container image used is now updated and doesn't conflict any more. Since the two points that we blocking the migration to Ubuntu 24.04 were the glibc version and the requirement for new system package, I think this PR can be merged :)

@germa89
germa89 enabled auto-merge (squash) April 14, 2025 09:47
@germa89

germa89 commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

@SMoraisAnsys failing again...

I guess a previous merge from main deleted your changes? Until I restored them in 257a8e7

Only the local tests fail.... I guess I am going to be forced to update to Ubuntu 24:04 ...

Ref: https://www.reddit.com/r/linux4noobs/comments/1bycyya/running_into_a_version_glibc_238_not_found_error/

@germa89

germa89 commented Apr 15, 2025

Copy link
Copy Markdown
Collaborator

Since this requires changes on the container, and I opened already an issue for that, I'm closing this PR. I will reopen it in the future.

https://github.com/ansys-internal/mapdl-docker-image-builder/issues/155

@germa89 germa89 closed this Apr 15, 2025
auto-merge was automatically disabled April 15, 2025 16:26

Pull request was closed

@germa89
germa89 deleted the ci/use-ubuntu-latest branch May 19, 2025 15:38
@germa89
germa89 restored the ci/use-ubuntu-latest branch July 9, 2025 16:20
@germa89 germa89 reopened this Jul 9, 2025
@germa89

germa89 commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

Summary

Every workflow has been updated to ubuntu-latest except test-local because it is running locally inside the container giving a GLIBC_2.38 lib error when running python:

Run python --version
python: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.38' not found (required by /__t/Python/3.12.11/x64/lib/libpython3.12.so.1.0)
python: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.38' not found (required by /__t/Python/3.12.11/x64/lib/libpython3.12.so.1.0)

Only solution seems to be keep using ubuntu-22.04 or update the container to use ubuntu-24.04.

Ref: actions/setup-python#1053

@germa89

germa89 commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

@SMoraisAnsys can I have a verbal approval for this PR?

@germa89 germa89 self-assigned this Jul 10, 2025
@SMoraisAnsys

Copy link
Copy Markdown
Contributor Author

@SMoraisAnsys can I have a verbal approval for this PR?

Yup, all fine. Glad this can be updated. Note that you might want to notify @klmcadams as I remember she seems to be following the same image as you in another repo.

@germa89

germa89 commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

@SMoraisAnsys can I have a verbal approval for this PR?

Yup, all fine. Glad this can be updated. Note that you might want to notify @klmcadams as I remember she seems to be following the same image as you in another repo.

True. However, I believe she is running inside the container (local) so she must not be able to apply this change until I upgrade the container... eventually I will find the time.

@germa89
germa89 merged commit f82e540 into main Jul 10, 2025
47 checks passed
@germa89
germa89 deleted the ci/use-ubuntu-latest branch July 10, 2025 14:39
@klmcadams

klmcadams commented Jul 14, 2025

Copy link
Copy Markdown

@SMoraisAnsys @germa89 We pinned ubuntu-22.04 in ansys-tools-path here.

also pinging @AlejandroFernandezLuces in case the new repo had to do something similar for the workflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants