Skip to content

docs: Update CONTRIBUTORS.md with the latest contributors - #3836

Merged
germa89 merged 2 commits into
mainfrom
maint/update-contributors-file
Apr 14, 2025
Merged

docs: Update CONTRIBUTORS.md with the latest contributors#3836
germa89 merged 2 commits into
mainfrom
maint/update-contributors-file

Conversation

@pyansys-ci-bot

Copy link
Copy Markdown
Contributor

Updated the CONTRIBUTORS.md file with the latest contributors.


This pull request was created by a bot. If you have any questions, please ping the PyAnsys Core team for assistance. To ping the team write a comment in this issue with the following mention: @ansys/pyansys-core.

If you want this repository to be excluded from this automated maintenance process, please let us know by filling in the opt-out request form.

@pyansys-ci-bot
pyansys-ci-bot requested a review from a team as a code owner April 13, 2025 22:39
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added the documentation Documentation related (improving, adding, etc) label Apr 13, 2025
@github-actions github-actions Bot added documentation Documentation related (improving, adding, etc) and removed documentation Documentation related (improving, adding, etc) labels Apr 13, 2025
@codecov

codecov Bot commented Apr 13, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.36%. Comparing base (d2791d3) to head (ca414cd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3836      +/-   ##
==========================================
- Coverage   88.41%   88.36%   -0.05%     
==========================================
  Files         187      187              
  Lines       14761    14761              
==========================================
- Hits        13051    13044       -7     
- Misses       1710     1717       +7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89

germa89 commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

@ansys/pyansys-core can we have case insensitive sorting?

@germa89 germa89 self-assigned this Apr 14, 2025
@RobPasMue

Copy link
Copy Markdown
Member

@ansys/pyansys-core can we have case insensitive sorting?

Hmm I think the main reason is the fact that the users you see at the end do not have a GH username apart from their handle so we are just appending them to the end. Maybe @klmcadams can elaborate on this. But it also makes sense to me to have them as is... because they are like "undefined" GH usernames, even though they have a GH handle. Anyway, I'm open to changing it, I'm just explaining why it could make sense to have it this way rn. I'll let @klmcadams decide what's best and what she prefers =)

@germa89

germa89 commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

that makes sense... It just looks strange. I'm merging then. We can figure out this according to Kerry in this in the next PR.

@germa89
germa89 enabled auto-merge (squash) April 14, 2025 09:32
@germa89
germa89 merged commit e0dd5d6 into main Apr 14, 2025
@germa89
germa89 deleted the maint/update-contributors-file branch April 14, 2025 09:33
@klmcadams

Copy link
Copy Markdown

@germa89 @RobPasMue I'm using the sorted function in python to do the sorting which is case sensitive, making the lowercase users move to the end. I looked it up and I could add .lower() to the sorted key to make it case insensitive, so I'll try that out & let you know how it goes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related (improving, adding, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants