Skip to content

fix: add check for artifacts directory before processing files - #3851

Merged
germa89 merged 2 commits into
mainfrom
ci/skip-pytest-summary-when-no-artifacts
Apr 21, 2025
Merged

fix: add check for artifacts directory before processing files#3851
germa89 merged 2 commits into
mainfrom
ci/skip-pytest-summary-when-no-artifacts

Conversation

@germa89

@germa89 germa89 commented Apr 21, 2025

Copy link
Copy Markdown
Collaborator

Description

Avoid running pytest-summary step if no artifacts have been downloaded.

Issue linked

NA

Checklist

@germa89
germa89 requested a review from a team as a code owner April 21, 2025 11:36
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Apr 21, 2025
@github-actions github-actions Bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) bug Issue, problem or error in PyMAPDL labels Apr 21, 2025
@codecov

codecov Bot commented Apr 21, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.33%. Comparing base (3801fe4) to head (2d1953f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3851      +/-   ##
==========================================
+ Coverage   88.30%   88.33%   +0.03%     
==========================================
  Files         187      187              
  Lines       14819    14819              
==========================================
+ Hits        13086    13091       +5     
+ Misses       1733     1728       -5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89

germa89 commented Apr 21, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@germa89
germa89 enabled auto-merge (squash) April 21, 2025 13:23

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
germa89 merged commit 47f1731 into main Apr 21, 2025
@germa89
germa89 deleted the ci/skip-pytest-summary-when-no-artifacts branch April 21, 2025 13:23
@germa89

germa89 commented Apr 21, 2025

Copy link
Copy Markdown
Collaborator Author

Checked in https://github.com/ansys/pymapdl/actions/runs/14574243054/job/40876920604

GitHub
A Python client library for Ansys MAPDL. Contribute to ansys/pymapdl development by creating an account on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants