hold the bc settings per plotter instance - #3897
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Contributor
Reviewer's GuideThis pull request refactors boundary condition (BC) plot settings to be instance-specific rather than global. It introduces a File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## check-installed-without-import #3897 +/- ##
==================================================================
- Coverage 88.28% 88.28% -0.01%
==================================================================
Files 187 187
Lines 14823 14830 +7
==================================================================
+ Hits 13087 13092 +5
- Misses 1736 1738 +2 🚀 New features to boost your workflow:
|
koubaa
added a commit
that referenced
this pull request
May 7, 2025
…ing ansys.mapdl.core (#3887) * change how the install check works * chore: adding changelog file 3887.miscellaneous.md [dependabot-skip] * chore: adding changelog file 3887.added.md [dependabot-skip] * don't expect requests to be loaded on import * only set the default theme once * use default symbol * Don't import plotter from visualizer by default Don't import plotter from post module * ci: auto fixes from pre-commit.com hooks. for more information, see https://pre-commit.ci * remove global import of Plotter * chore: adding changelog file 3887.added.md [dependabot-skip] * cicd: empty commit to retrigger CICD * fix ci * update * fix autodoc * hold the bc settings per plotter instance (#3897) * hold the bc settings per plotter instance * ci: auto fixes from pre-commit.com hooks. for more information, see https://pre-commit.ci * chore: adding changelog file 3897.miscellaneous.md [dependabot-skip] --------- Co-authored-by: Mohamed Koubaa <koubaa@github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> * add docstring * type hint --------- Co-authored-by: Mohamed Koubaa <koubaa@github.com> Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: German <28149841+germa89@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Modify the visualizer to hold BC (boundary condition) settings per plotter instance instead of using a global variable
Enhancements: