Skip to content

fix: update changelog title format to include 'v' prefix for version#3908

Merged
germa89 merged 2 commits into
mainfrom
fix/double-reference-in-changelog
May 9, 2025
Merged

fix: update changelog title format to include 'v' prefix for version#3908
germa89 merged 2 commits into
mainfrom
fix/double-reference-in-changelog

Conversation

@germa89

@germa89 germa89 commented May 8, 2025

Copy link
Copy Markdown
Collaborator

Description

As the title. Fix release process.

Issue linked

NA

Checklist

Summary by Sourcery

Chores:

  • Modified towncrier configuration to add 'v' prefix to changelog version reference

@germa89 germa89 requested a review from a team as a code owner May 8, 2025 18:46
@germa89 germa89 requested review from clatapie and pyansys-ci-bot May 8, 2025 18:46
@sourcery-ai

sourcery-ai Bot commented May 8, 2025

Copy link
Copy Markdown
Contributor

Reviewer's Guide

This pull request updates the changelog title format in pyproject.toml by prefixing the version with 'v' in the reStructuredText reference label. This was achieved by modifying the title_format string within the [tool.towncrier] configuration from _{version} to _v{version}.

File-Level Changes

Change Details Files
Updated changelog title format to include 'v' prefix for the version in the reStructuredText reference label.
  • Modified the title_format string in the [tool.towncrier] section by changing _{version}: to _v{version}:.
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions Bot added dependencies maintenance General maintenance of the repo (libraries, cicd, etc) bug Issue, problem or error in PyMAPDL labels May 8, 2025
@germa89 germa89 self-assigned this May 8, 2025
@codecov

codecov Bot commented May 8, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (8809b5a) to head (c93824e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3908      +/-   ##
==========================================
- Coverage   88.32%   88.28%   -0.05%     
==========================================
  Files         187      187              
  Lines       14830    14830              
==========================================
- Hits        13099    13092       -7     
- Misses       1731     1738       +7     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89

germa89 commented May 9, 2025

Copy link
Copy Markdown
Collaborator Author

I forgot to ping @klmcadams ... but I guess this is the right approach from:

ansys/actions#804 (comment)

@germa89

germa89 commented May 9, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@germa89 germa89 enabled auto-merge (squash) May 9, 2025 07:12

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 85c3804 into main May 9, 2025
50 checks passed
@germa89 germa89 deleted the fix/double-reference-in-changelog branch May 9, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL dependencies maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants