fix: Change the mapdl_inprocess graphics backend - #3915
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Contributor
Reviewer's GuideThis pull request updates the Class Diagram: Update to MapdlCore for Graphics Backend HandlingclassDiagram
class MapdlCore {
+__init__(self, ..., graphics_backend: Optional[GraphicsBackend] = None, **kwargs)
- _graphics_backend: GraphicsBackend
# Other methods and attributes...
}
class GraphicsBackend {
<<enumeration>>
PYVISTA
MAPDL
NONE
# Potentially other enum values
}
MapdlCore ..> GraphicsBackend : uses
note for MapdlCore "__init__ method updated:\nPrevents ModuleNotFoundError if 'graphics_backend' is GraphicsBackend.MAPDL,\neven when optional graphics dependencies are not installed."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @koubaa - I've reviewed your changes - here's some feedback:
- When
graphics_backendisGraphicsBackend.MAPDLand PyVista is unavailable, ensureself._graphics_backendis explicitly assigned toGraphicsBackend.MAPDLto fully enable its functionality, not just bypass the error.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
`mapdl_inprocess` should use `None`for graphics backend. This will have to be revisited with some automated tests when 2025R2 is released.
koubaa
force-pushed
the
fix-mapdl-graphics-backend
branch
from
May 9, 2025 16:26
2efb018 to
d506984
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3915 +/- ##
==========================================
- Coverage 88.28% 88.27% -0.01%
==========================================
Files 187 187
Lines 14830 14830
==========================================
- Hits 13092 13091 -1
- Misses 1738 1739 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3916
mapdl_inprocessshould useNonefor graphics backend. This will have to be revisited with some automated tests when 2025R2 is released.