fix: documentation html looks - #3918
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Contributor
Reviewer's GuideThis PR restores the navbar’s intended styling and layout by refining custom CSS rules to center elements and eliminate unwanted shadows, and by updating the Sphinx configuration to streamline sidebars and navbar items. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- In custom.css, the .sd-shadow-sm rule is missing a semicolon after the !important declaration—please add it to ensure proper parsing.
- The old html_sidebars and commented sidebar settings in conf.py should be removed or consolidated with the new secondary_sidebar_items configuration to avoid confusion.
- After removing the theme-specific CSS overrides, test both light and dark themes to confirm the navbar and other elements retain the intended styles consistently.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Collaborator
Author
|
Related to: ansys/ansys-sphinx-theme#691 |
Collaborator
Author
|
Asking sphinx/UI guys for a quick review @jorgepiloto @Revathyvenugopal162 |
…ion header formatting
Collaborator
Author
|
Also related to: ansys/ansys-sphinx-theme#693 |
Revathyvenugopal162
approved these changes
May 12, 2025
…ince it does not affect. Waiting for ansys-sphinx-theme release
germa89
enabled auto-merge (squash)
May 12, 2025 12:58
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Latest release broke the navbar color.
Taking advantage of this PR and also do more stuff:
Edit on GitHublink to the end of primary bar.Details
Navbar color
Centering navbar elements
Before
After
Moving search field to sidebar on small devices
Before
After
Removing secondary sidebar in all pages.
Before
After
Issue linked
Close #3914
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)