Repository navigation
ci: annotating launcher, convert and commands files - #3935
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideIntegrates static typing checks by adding MyPy to pre-commit, refactors version retrieval logic, and adds type annotations across core modules. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @germa89 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3935 +/- ##
==========================================
+ Coverage 88.27% 88.28% +0.01%
==========================================
Files 187 187
Lines 14840 14906 +66
==========================================
+ Hits 13100 13160 +60
- Misses 1740 1746 +6 🚀 New features to boost your workflow:
|
…s/pymapdl into maint/annotating-some-files
|
MyPy support is added on the local precommit. But I had to disable it in the CICD because it keeps trying to analyse all the repository. |
…s/pymapdl into maint/annotating-some-files
|
@pyansys-ci-bot LGTM. |

Description
Using MyPy for typing annotations checks on the files: launcher, conver and commands.
Issue linked
Related to #3480
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Enforce static type checking with MyPy and add missing type annotations in core files
Enhancements:
CI: