Repository navigation
refactor: enhance error reporting in pytest output for better debugging - #3943
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Contributor
Reviewer's GuideCentralize error message parsing in get_error_message and apply across pytest summary output, while extending reporting to skipped tests for improved debugging. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
germa89
enabled auto-merge (squash)
May 22, 2025 12:32
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
Contributor
There was a problem hiding this comment.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Rather than parsing
rep.longreprtext.splitlines(), consider usingrep.longrepr.reprcrash.pathandrep.longrepr.reprcrash.messagefor a more robust extraction of filename, line number, and error message. - The inline
get_error_messagefunction could be moved out of the hook and into a shared utility to make it easier to test and reuse across other pytest hooks. - Be cautious with
ast.literal_evalonrep.longreprtextlines, as complex or parameterized failures might not match the expected tuple format—adding a fallback for unparsable cases would avoid exceptions in the summary.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…https://github.com/ansys/pymapdl into feat/enhance-error-reporting-in-pytest-output
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3943 +/- ##
==========================================
+ Coverage 88.27% 88.34% +0.06%
==========================================
Files 187 187
Lines 14840 14906 +66
==========================================
+ Hits 13100 13168 +68
+ Misses 1740 1738 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
As the title.
Issue linked
Spin out of #1300
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Enhance Pytest output by parsing report details to provide concise, consistent summaries of test failures, errors, and skips
Enhancements:
Tests: