Repository navigation
feat: enhance error handling with color support and additional notes in exceptions. - #3964
Merged
Merged
Conversation
…in exceptions. Adding stdout and stderr in MapdlDidntstart exception. Also refactor by removing unnecesary code.
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Contributor
|
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Refactor color_text to accept a bcolors enum (or validate string keys) instead of raw strings to prevent KeyError at runtime.
- DRY up the duplicated str logic by having MapdlDidNotStart call super().str and then append its additional stdout/stderr/notes instead of reimplementing the entire method.
- In retrieve_mapdl_from_args, prefer using isinstance checks or a shared protocol rather than matching on class.name for more reliable type detection.
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3964 +/- ##
==========================================
+ Coverage 88.28% 88.30% +0.02%
==========================================
Files 187 187
Lines 14906 14935 +29
==========================================
+ Hits 13160 13189 +29
Misses 1746 1746 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
germa89
enabled auto-merge (squash)
May 29, 2025 09:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
As the title and adding stdout and stderr attributes in MapdlDidntstart exception.
Also refactor by removing unnecesary code.
Issue linked
NA
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Enhance exception handling with ANSI color support, additional notes and output details, and streamline exception class definitions
New Features:
Enhancements: