fix: selection on non-interactive - #3998
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Contributor
Reviewer's GuideRestore command execution in non-interactive mode by modifying the inner_wrapper early return to call the wrapped function, and improve test coverage by renaming existing tests for clarity and adding a parameterized test for node selection under non-interactive conditions. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @germa89 - I've reviewed your changes - here's some feedback:
- Consider renaming
_store_commandsto something like_non_interactive_modeor_deferred_executionto better reflect its purpose and improve readability. - Add analogous tests for other selection methods (e.g.
esel,csel) to ensure this non‐interactive execution fix applies consistently across all *_sel commands. - Ensure the non_interactive context manager fully restores the original interactive state on exit so that selection state doesn’t leak into subsequent operations.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
germa89
commented
Jun 10, 2025
…and simplify selection condition in tests
…/ansys/pymapdl into fix/selection-on-non-interactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3998 +/- ##
==========================================
+ Coverage 89.11% 89.12% +0.01%
==========================================
Files 187 187
Lines 14970 14970
==========================================
+ Hits 13340 13342 +2
+ Misses 1630 1628 -2 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
germa89
enabled auto-merge (squash)
June 10, 2025 09:27
germa89
added a commit
that referenced
this pull request
Aug 4, 2025
* fix: ensure command execution in interactive mode when storing commands * test: add parameterized test for selection on non-interactive mode * chore: adding changelog file 3998.miscellaneous.md [dependabot-skip] * refactor: clarify non-interactive mode behavior in command execution and simplify selection condition in tests * test: parameterize selection tests for non-interactive mode * test: refactor selection tests for non-interactive mode into a class-based structure --------- Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fix not running xsel commands in non_interactive.
Issue linked
Close #3989
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Fix selection commands not executing in non-interactive mode and update related tests.
Bug Fixes:
Tests: