Skip to content

revert: "test: removing composite example" - #4000

Merged
germa89 merged 12 commits into
mainfrom
docs/readding-composite-dpf-example
Jun 17, 2025
Merged

revert: "test: removing composite example"#4000
germa89 merged 12 commits into
mainfrom
docs/readding-composite-dpf-example

Conversation

@germa89

@germa89 germa89 commented Jun 11, 2025

Copy link
Copy Markdown
Collaborator

This reverts commit 917ca90.

Description

This PR readd the composite DPF example which was removed because of failures.

Issue linked

Close #3486

Checklist

Summary by Sourcery

Revert the previous removal of the composite example by restoring the composite_dcb.py demonstration and updating the changelog accordingly

New Features:

  • Reintroduce the composite double cantilever beam cohesive element simulation example

Documentation:

  • Add changelog entry for revert of composite example removal

@germa89
germa89 requested a review from a team as a code owner June 11, 2025 07:57
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jun 11, 2025
@github-actions github-actions Bot added examples Publishing PyMAPDL examples documentation Documentation related (improving, adding, etc) maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 11, 2025
@github-actions github-actions Bot added maintenance General maintenance of the repo (libraries, cicd, etc) and removed maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 11, 2025

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @germa89 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread examples/00-mapdl-examples/composite_dcb.py
Comment thread examples/00-mapdl-examples/composite_dcb.py
Comment thread examples/00-mapdl-examples/composite_dcb.py
Comment thread examples/00-mapdl-examples/composite_dcb.py Outdated
Comment thread examples/00-mapdl-examples/composite_dcb.py Outdated
@github-actions github-actions Bot added maintenance General maintenance of the repo (libraries, cicd, etc) and removed maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 16, 2025
@germa89

germa89 commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator Author

@PProfizi @rafacanton could you have a look at this commit and tell me if this is the best approach to consider both cases, a remote DPF server running on port DPF_PORT and a local MAPDL installation?

This is the commit: cc5a3f3

@germa89

germa89 commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator Author

I think I could also use dpf.server.has_local_server()??

@github-actions github-actions Bot added maintenance General maintenance of the repo (libraries, cicd, etc) and removed maintenance General maintenance of the repo (libraries, cicd, etc) labels Jun 16, 2025
@github-actions github-actions Bot added the CI/CD Related with CICD, Github Actions, etc label Jun 16, 2025
@codecov

codecov Bot commented Jun 16, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (a6e939a) to head (674ab6d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4000      +/-   ##
==========================================
+ Coverage   89.12%   89.13%   +0.01%     
==========================================
  Files         187      187              
  Lines       14970    14970              
==========================================
+ Hits        13342    13344       +2     
+ Misses       1628     1626       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89

germa89 commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator Author

Elements selections seems to have problems still when not all the nodes are selected for the elements we want to plot.

Related to #3782

@rafacanton

Copy link
Copy Markdown

@PProfizi @rafacanton could you have a look at this commit and tell me if this is the best approach to consider both cases, a remote DPF server running on port DPF_PORT and a local MAPDL installation?

This is the commit: cc5a3f3

@germa89 I see a couple of things:

  • Why not passing the ip as well?
  • In either the in-process or gRPC case you are connecting to the server and creating a variable, dpf_server. This just stablishes the connection. However, you are not explicitly saying that you are going to run the subsequent operators in that server. To do that, you either:
    • Use dpf_server to instantiate operators, e.g.: model = dpf.Model(path_source, dpf_server)
    • Set the server as global at construction, e.g.: dpf_server = dpf.server.connect_to_server(port=int(os.environ["DPF_PORT"]), as_global=True). This seems to be the default, but better explicit than implicit.

@germa89

germa89 commented Jun 17, 2025

Copy link
Copy Markdown
Collaborator Author

@rafacanton

Because DPF is running on a container, and that container binds the port 50055, I just need to tell the port because the IP is "local".

I was trusting on the as_global argument, but sure, I will explicitly code it.

Thank you a lot @rafacanton !

@germa89

germa89 commented Jun 17, 2025

Copy link
Copy Markdown
Collaborator Author

It looks great. Pinging @rmanno91 for awareness. Sorry it took so long!

@germa89

germa89 commented Jun 17, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@germa89
germa89 enabled auto-merge (squash) June 17, 2025 09:56

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
germa89 merged commit 1591ae8 into main Jun 17, 2025
@germa89
germa89 deleted the docs/readding-composite-dpf-example branch June 17, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc documentation Documentation related (improving, adding, etc) examples Publishing PyMAPDL examples maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removed DPF CDB example because unknown failure

4 participants