Skip to content

fix: update import paths and add verification files to examples - #4038

Merged
germa89 merged 2 commits into
mainfrom
feat/adding-examples-to-example-modules
Jun 25, 2025
Merged

germa89 merged 2 commits into
mainfrom
feat/adding-examples-to-example-modules

Conversation

@germa89

@germa89 germa89 commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

Description

As the title.

Issue linked

Extracted from #1300

Checklist

Summary by Sourcery

Fix import path resolution in examples and expand the examples module with verification file references

Bug Fixes:

  • Rename examples module path variable from dir_path to __dir_path for consistent import resolution

Enhancements:

  • Import verification file mapping and expose multiple vm examples in ansys.mapdl.core.examples

@germa89
germa89 requested a review from a team as a code owner June 25, 2025 11:37
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 self-assigned this Jun 25, 2025
@sourcery-ai

sourcery-ai Bot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

Reviewer's Guide

This PR refactors how example file paths are resolved by updating the module‐level path variable and integrates a suite of verification input files by importing them and exposing each as a top‐level example variable.

Class diagram for updated examples module structure

classDiagram
    class examples.py {
        - __dir_path: str
        - wing_model: str
        + laterally_loaded_tapered_support_structure
        + pinched_cylinder
        + transient_thermal_stress_in_a_cylinder
        + elongation_of_a_solid_bar
        + natural_frequency_of_a_piezoelectric_transducer
        + frequency_response_of_electrical_input_admittance
        + electrothermal_microactuator_analysis
        + piezoelectric_rectangular_strip_under_pure_bending_load
        + transient_response_of_a_ball_impacting_a_flexible_surface
        + threed_nonaxisymmetric_vibration_of_a_stretched_membrane
        + modal_analysis_of_a_cyclic_symmetric_annular_plate
    }
    class vmfiles {
        + ["vm5"]
        + ["vm6"]
        + ["vm33"]
        + ["vm37"]
        + ["vm175"]
        + ["vm176"]
        + ["vm223"]
        + ["vm231"]
        + ["vm65"]
        + ["vm155"]
        + ["vm244"]
    }
    examples.py ..> vmfiles : imports and exposes verification files
Loading

File-Level Changes

Change Details Files
Refactor example path resolution variable
  • Renamed module-level path variable from dir_path to __dir_path
  • Updated wing_model to reference __dir_path
src/ansys/mapdl/core/examples/examples.py
Integrate verification files into examples
  • Imported vmfiles mapping from ansys.mapdl.core.examples.verif_files
  • Added multiple example variables referencing entries in the vmfiles mapping
src/ansys/mapdl/core/examples/examples.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@germa89

germa89 commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@germa89
germa89 enabled auto-merge (squash) June 25, 2025 11:37

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @germa89 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions github-actions Bot added the bug Issue, problem or error in PyMAPDL label Jun 25, 2025
@codecov

codecov Bot commented Jun 25, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (53ad87c) to head (3492605).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4038      +/-   ##
==========================================
+ Coverage   89.05%   89.13%   +0.08%     
==========================================
  Files         187      187              
  Lines       14970    14983      +13     
==========================================
+ Hits        13331    13355      +24     
+ Misses       1639     1628      -11     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
germa89 merged commit 47424c3 into main Jun 25, 2025
@germa89
germa89 deleted the feat/adding-examples-to-example-modules branch June 25, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants