fix: add curl installation to fix codecov upload - #4070
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Contributor
Reviewer's GuideUpdated CI test-local workflow to install curl, ensuring the codecov upload script can run successfully. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures curl is installed in the CI environment so that the Codecov upload script can run successfully.
- Added
curlto the list of OS packages for minimal and full testing workflows. - Retained cleanup commands after installation.
Comments suppressed due to low confidence (2)
.github/workflows/test-local.yml:179
- [nitpick] Consider using
apt-get install -y --no-install-recommendsand cleaning up/var/lib/apt/lists/*(e.g.,rm -rf /var/lib/apt/lists/*) to reduce the image footprint.
apt-get update && apt install -y libgomp1 graphviz curl && apt-get clean
.github/workflows/test-local.yml:185
- [nitpick] Similarly, for consistency and smaller CI environments, use
--no-install-recommendsand remove APT lists after installation.
apt-get update && apt install -y libgl1-mesa-glx xvfb libgomp1 graphviz curl && apt-get clean
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4070 +/- ##
==========================================
+ Coverage 89.02% 91.80% +2.77%
==========================================
Files 187 187
Lines 14993 14993
==========================================
+ Hits 13348 13764 +416
+ Misses 1645 1229 -416 🚀 New features to boost your workflow:
|
germa89
enabled auto-merge (squash)
July 2, 2025 12:08
germa89
disabled auto-merge
July 2, 2025 12:08
germa89
enabled auto-merge (squash)
July 2, 2025 13:42
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
I realised that the local testing coverage results weren't being uploaded to codecov. See the log:
Link: https://github.com/ansys/pymapdl/actions/runs/16023515132/job/45206036644?pr=1300#step:20:360
Issue linked
NA
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Install curl in the GitHub Actions test-local workflow to fix Codecov upload failures.
Bug Fixes:
CI: