feat: implement platform-specific path handling in mapdl.directory

[germa89]

Description

As the title.

So we can do:

>>> err_file = mapdl.directory / 'file.err'
PurePosixPath('/local/simulation/file.err')

Issue linked

Close #4078

Checklist

• I have visited and read Develop PyMAPDL.
• I have tested my changes locally
• I have added necessary documentation or updated existing documentation.
• I have followed the PyMAPDL coding style guidelines.
• I have added appropriate unit tests that also ensure the minimal coverage criteria.
• I have reviewed my changes before submitting this pull request.
• I have linked the issue or issues that are solved to the PR if any.
• I have assigned this PR to myself.
• I have marked this PR as draft if it is not ready to be reviewed yet.
• I have made sure that the title of my PR follows Commit naming conventions (e.g. feat: adding new MAPDL command)

Summary by Sourcery

Introduce OS-aware path handling for mapdl.directory by wrapping paths in pathlib.PureWindowsPath or pathlib.PurePosixPath, and update tests accordingly

New Features:

• Implement platform-specific path handling in mapdl.directory by returning PureWindowsPath or PurePosixPath based on the running OS

Enhancements:

• Wrap directory getter and setter to always normalize internal paths through the new _wrap_directory helper

Tests:

• Update existing tests to use pathlib.PurePath comparisons instead of Path
• Add test_directory_pathlib to verify that mapdl.directory returns a PurePath and supports OS-specific path joining

[ansys-reviewer-bot]

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

[sourcery-ai]

Reviewer's Guide

This PR introduces platform-aware path handling by wrapping the Mapdl working directory string in an OS-specific pathlib.PurePath object via a new helper and updates the directory getter/setter to use it, with corresponding adjustments to existing tests and a new test for join behavior.

Class diagram for updated Mapdl directory path handling

classDiagram
    class MapdlCore {
        +platform: str
        +_path: pathlib.PurePath
        +directory: property
        +directory(path: Union[str, pathlib.Path])
        +_wrap_directory(path: str) pathlib.PurePath
    }
    MapdlCore --> "1" pathlib.PurePath : uses
    class pathlib.PurePath
    class pathlib.PureWindowsPath
    class pathlib.PurePosixPath
    pathlib.PureWindowsPath --|> pathlib.PurePath
    pathlib.PurePosixPath --|> pathlib.PurePath
    MapdlCore ..> pathlib.PureWindowsPath : returns if platform=="windows"
    MapdlCore ..> pathlib.PurePosixPath : returns if platform=="linux" or fallback

Loading

Class diagram for _wrap_directory helper method

classDiagram
    class MapdlCore {
        +_wrap_directory(path: str) pathlib.PurePath
    }
    class pathlib.PureWindowsPath
    class pathlib.PurePosixPath
    MapdlCore ..> pathlib.PureWindowsPath : returns on Windows
    MapdlCore ..> pathlib.PurePosixPath : returns on Linux/Other

Loading

File-Level Changes

Change	Details	Files
Introduce _wrap_directory helper to return OS-specific PurePath	Added _wrap_directory(path) method to determine OS and return PureWindowsPath or PurePosixPath Included fallback warning for unknown OS Centralized path conversion logic in one place	src/ansys/mapdl/core/mapdl_core.py
Refactor directory property to leverage the wrapper	Replaced direct assignments to self._path with calls to _wrap_directory in getter Updated setter to wrap incoming paths before storing Adjusted return type to PurePath instead of raw string	src/ansys/mapdl/core/mapdl_core.py
Revise tests for PurePath return and joining behavior	Converted assertions to use pathlib.Path or PurePath instead of Path alone Updated existing tests to compare str(mapdl.directory) with expected paths Added new test_directory_pathlib to verify return type and OS-specific join behavior	tests/test_mapdl.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#4078	Return a Pathlib.Path object from mapdl.directory that takes into account the OS of MAPDL.	✅
#4078	Allow users to manipulate MAPDL paths using / operator.	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @germa89 - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[Copilot]

Pull Request Overview

This PR adds platform-aware path handling for the mapdl.directory property, so it now returns a PurePath specific to Windows or POSIX and updates tests to use pathlib.

• Introduces _wrap_directory to produce PureWindowsPath or PurePosixPath depending on mapdl.platform.
• Updates the directory getter/setter to call _wrap_directory instead of storing raw strings.
• Refactors tests to import pathlib and assert against PurePath behavior.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/test_mapdl.py	Switched from Path import to pathlib, added a new test to assert PurePath behavior.
src/ansys/mapdl/core/mapdl_core.py	Added _wrap_directory and updated directory getter/setter to return PurePath objects.

Comments suppressed due to low confidence (1)

src/ansys/mapdl/core/mapdl_core.py:559

• The directory property is annotated to return str but now returns a pathlib.PurePath. Update the return type annotation to pathlib.PurePath (or Union[str, pathlib.PurePath]) to reflect the new behavior.

            path = path.replace("\\", "/")

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (e45c8a4) to head (b78c04b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4079      +/-   ##
==========================================
- Coverage   91.84%   91.80%   -0.05%     
==========================================
  Files         187      187              
  Lines       15023    15032       +9     
==========================================
+ Hits        13798    13800       +2     
- Misses       1225     1232       +7     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[germa89]

@pyansys-ci-bot LGTM.

[pyansys-ci-bot]

✅ Approving this PR because germa89 said so in here 😬