Repository navigation
fix: handle root directory case in test - #4087
Merged
Merged
Conversation
…n-Windows platforms
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Contributor
Reviewer's GuideThe test for directory path generation now correctly handles a root directory ("/") by introducing a conditional branch, ensuring the constructed path matches expected behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the directory path test to correctly handle when mapdl.directory is the root ("/"), preventing a double-slash in the generated path.
- Adds a special case for
mapdl.directory == "/"within the non-Windows branch. - Preserves existing Windows path logic.
Comments suppressed due to low confidence (1)
tests/test_mapdl.py:2763
- This
else:is indented under the previous statement rather than matching the initialif; it will cause a syntax error. Consider usingelif mapdl.directory == "/":aligned with theif mapdl.platform == "windows"block or adjust the indentation so the branches are at the same level.
else:
…nto fix/pathlib-test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4087 +/- ##
==========================================
+ Coverage 91.71% 91.82% +0.11%
==========================================
Files 187 187
Lines 15032 15033 +1
==========================================
+ Hits 13786 13804 +18
+ Misses 1246 1229 -17 🚀 New features to boost your workflow:
|
germa89
enabled auto-merge (squash)
July 9, 2025 16:37
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
dts12263
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
As thet title.
Fix test running internally
Issue linked
NA
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Bug Fixes: