Skip to content

fix: handle root directory case in test - #4087

Merged
germa89 merged 5 commits into
mainfrom
fix/pathlib-test
Jul 10, 2025
Merged

germa89 merged 5 commits into
mainfrom
fix/pathlib-test

Conversation

@germa89

@germa89 germa89 commented Jul 9, 2025 •

Copy link
Copy Markdown
Collaborator

Description

As thet title.

Fix test running internally

Issue linked

NA

Checklist

Summary by Sourcery

Bug Fixes:

  • Special-case root directory ('/') in test_mapdl.py to build correct file path for RST file

Copilot AI review requested due to automatic review settings July 9, 2025 15:43
@germa89
germa89 requested a review from a team as a code owner July 9, 2025 15:43
@germa89 germa89 self-assigned this Jul 9, 2025
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@sourcery-ai

sourcery-ai Bot commented Jul 9, 2025 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

The test for directory path generation now correctly handles a root directory ("/") by introducing a conditional branch, ensuring the constructed path matches expected behavior.

File-Level Changes

Change Details Files
Add explicit root-directory handling in path construction
  • Insert an if mapdl.directory == '/' check
  • Construct path_rst as /{jobname}.rst when in root
  • Keep existing directory/jobname.rst logic for other directories
tests/test_mapdl.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @germa89 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment thread tests/test_mapdl.py Outdated
Comment thread tests/test_mapdl.py Outdated
Comment thread tests/test_mapdl.py Outdated
@github-actions github-actions Bot added the bug Issue, problem or error in PyMAPDL label Jul 9, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the directory path test to correctly handle when mapdl.directory is the root ("/"), preventing a double-slash in the generated path.

  • Adds a special case for mapdl.directory == "/" within the non-Windows branch.
  • Preserves existing Windows path logic.
Comments suppressed due to low confidence (1)

tests/test_mapdl.py:2763

  • This else: is indented under the previous statement rather than matching the initial if; it will cause a syntax error. Consider using elif mapdl.directory == "/": aligned with the if mapdl.platform == "windows" block or adjust the indentation so the branches are at the same level.
    else:

Comment thread tests/test_mapdl.py
@germa89
germa89 requested a review from dts12263 July 9, 2025 15:45
@codecov

codecov Bot commented Jul 9, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (3bfd1d1) to head (712f573).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4087      +/-   ##
==========================================
+ Coverage   91.71%   91.82%   +0.11%     
==========================================
  Files         187      187              
  Lines       15032    15033       +1     
==========================================
+ Hits        13786    13804      +18     
+ Misses       1246     1229      -17     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
germa89 enabled auto-merge (squash) July 9, 2025 16:37
@germa89

germa89 commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
germa89 merged commit 83672d5 into main Jul 10, 2025
@germa89
germa89 deleted the fix/pathlib-test branch July 10, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants