Repository navigation
fix: remove restriction on spaces in string values for MAPDL parameters - #4109
Merged
Merged
Conversation
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Contributor
Reviewer's GuideRemoved the prohibition on spaces in string values for MAPDL parameters by deleting the check that raised an error, so strings containing spaces are now accepted unchanged. Class diagram for _set_parameter method update in MAPDL parametersclassDiagram
class Parameters {
_set_parameter(name, value)
}
Parameters : - Removed check for spaces in string values
Parameters : - Now allows string values with spaces
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the restriction that prevented spaces in string values for MAPDL parameters. The change allows users to set string parameters with spaces, which was previously blocked by a ValueError.
- Removes the validation check that raised an error when spaces were found in string parameter values
germa89
commented
Jul 21, 2025
germa89
enabled auto-merge (squash)
July 21, 2025 18:50
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4109 +/- ##
==========================================
+ Coverage 91.30% 91.32% +0.01%
==========================================
Files 189 189
Lines 15649 15646 -3
==========================================
- Hits 14289 14288 -1
+ Misses 1360 1358 -2 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
As the title.
Issue linked
Close #3718
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Bug Fixes: