Skip to content

fix: remove restriction on spaces in string values for MAPDL parameters - #4109

Merged
germa89 merged 8 commits into
mainfrom
feat/allow-spaces-in-string-parameters
Jul 22, 2025
Merged

germa89 merged 8 commits into
mainfrom
feat/allow-spaces-in-string-parameters

Conversation

@germa89

@germa89 germa89 commented Jul 21, 2025 •

Copy link
Copy Markdown
Collaborator

Description

As the title.

Issue linked

Close #3718

Checklist

Summary by Sourcery

Bug Fixes:

  • Remove the ValueError raised when setting string parameters containing spaces

Copilot AI review requested due to automatic review settings July 21, 2025 10:27
@germa89
germa89 requested a review from a team as a code owner July 21, 2025 10:27
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@sourcery-ai

sourcery-ai Bot commented Jul 21, 2025 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Removed the prohibition on spaces in string values for MAPDL parameters by deleting the check that raised an error, so strings containing spaces are now accepted unchanged.

Class diagram for _set_parameter method update in MAPDL parameters

classDiagram
    class Parameters {
        _set_parameter(name, value)
    }
    Parameters : - Removed check for spaces in string values
    Parameters : - Now allows string values with spaces
Loading

File-Level Changes

Change Details Files
Allow spaces in string parameter values
  • Deleted conditional raising ValueError for spaces in strings
src/ansys/mapdl/core/parameters.py

Assessment against linked issues

Issue Objective Addressed Explanation
#3718 Allow assignment of string parameters containing spaces in MAPDL via mapdl.parameters['name'] = 'string with spaces'. ✅

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@germa89 germa89 self-assigned this Jul 21, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the restriction that prevented spaces in string values for MAPDL parameters. The change allows users to set string parameters with spaces, which was previously blocked by a ValueError.

  • Removes the validation check that raised an error when spaces were found in string parameter values

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @germa89 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions github-actions Bot added the bug Issue, problem or error in PyMAPDL label Jul 21, 2025
Comment thread tests/test_mapdl.py Resolved
@germa89
germa89 enabled auto-merge (squash) July 21, 2025 18:50
@germa89

germa89 commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@codecov

codecov Bot commented Jul 21, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (86fa0c0) to head (31e6052).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4109      +/-   ##
==========================================
+ Coverage   91.30%   91.32%   +0.01%     
==========================================
  Files         189      189              
  Lines       15649    15646       -3     
==========================================
- Hits        14289    14288       -1     
+ Misses       1360     1358       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
germa89 merged commit e4862aa into main Jul 22, 2025
@germa89
germa89 deleted the feat/allow-spaces-in-string-parameters branch July 22, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spaces not allowed in strings in MAPDL

3 participants