Repository navigation
feat: parameterize tests for element and volume selection in post-processing - #4110
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Reviewer's GuideRefactors post-processing tests by parameterizing incomplete element and node selection ranges and introducing a parameterized volume selection test using pytest.mark.parametrize and dynamic mesh-based calculations. File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors post-processing tests to use parameterized testing for element and node selection scenarios. The changes improve test coverage by systematically testing various selection ranges and increments, while also ensuring that incomplete selection plots function correctly.
- Converts hardcoded test cases to parameterized tests using pytest.mark.parametrize
- Adds systematic testing of different selection ranges (0-100%, 20-30%, etc.) with various increments
- Separates volume selection testing into a dedicated parameterized test method
Comments suppressed due to low confidence (1)
tests/test_post.py:1284
- The function name 'test_plot_incomplete_node_selection' should be 'test_plot_incomplete_nodal_selection' to maintain consistency with the original function name and the nodal displacement method being tested.
def test_plot_incomplete_node_selection(mapdl, resume, vmin, vmax, vinc):
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4110 +/- ##
==========================================
- Coverage 91.39% 91.36% -0.04%
==========================================
Files 189 189
Lines 15667 15667
==========================================
- Hits 14319 14314 -5
- Misses 1348 1353 +5 🚀 New features to boost your workflow:
|
|
@pyansys-ci-bot LGTM. |

Description
As the title.
Also making sure we can do uncomplete selection plots.
Issue linked
Close #3782
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)Summary by Sourcery
Parameterize post-processing tests for incomplete element and node selections and add volume-based selection tests to verify plotting behavior with partial selections
Enhancements: