Skip to content

feat: allow PSD plots to show - #4116

Merged
germa89 merged 2 commits into
mainfrom
feat/plotting-psd-graphs
Jul 22, 2025
Merged

feat: allow PSD plots to show#4116
germa89 merged 2 commits into
mainfrom
feat/plotting-psd-graphs

Conversation

@germa89

@germa89 germa89 commented Jul 21, 2025

Copy link
Copy Markdown
Collaborator

Description

As the title.

Issue linked

Close #906

Checklist

Summary by Sourcery

New Features:

  • Add PSDG and SPGR to supported plot commands to enable PSD and spectral group visualizations

Copilot AI review requested due to automatic review settings July 21, 2025 18:43
@germa89
germa89 requested a review from a team as a code owner July 21, 2025 18:44
@ansys-reviewer-bot

Copy link
Copy Markdown
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@sourcery-ai

sourcery-ai Bot commented Jul 21, 2025

Copy link
Copy Markdown
Contributor

Reviewer's Guide

PLOT_COMMANDS in mapdl_core.py is extended to include PSDG and SPGR, enabling PSD and spectral plots to be displayed by the core plotting logic.

Class diagram for updated PLOT_COMMANDS in mapdl_core.py

classDiagram
    class mapdl_core {
        +PLOT_COMMANDS: List[str]
        ...
    }
    note for mapdl_core "PLOT_COMMANDS now includes 'PSDG' and 'SPGR' for PSD and spectral plots."
Loading

File-Level Changes

Change Details Files
Extend PLOT_COMMANDS whitelist to support PSD plots
  • Added 'PSDG' and 'SPGR' entries to the PLOT_COMMANDS list
src/ansys/mapdl/core/mapdl_core.py

Assessment against linked issues

Issue Objective Addressed Explanation
#906 Enable plotting of the PSD input curve using mapdl.psdgraph(1) so that the plot is displayed or accessible.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@germa89 germa89 self-assigned this Jul 21, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Power Spectral Density (PSD) plots by including PSD-related commands in the PLOT_COMMANDS list. This change allows PSD plots to be properly displayed in PyMAPDL.

  • Refactored PLOT_COMMANDS from inline list to multi-line format for better readability
  • Added "PSDG" and "SPGR" commands to enable PSD plotting functionality

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @germa89 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@github-actions github-actions Bot added the new feature Request or proposal for a new feature label Jul 21, 2025
@codecov

codecov Bot commented Jul 21, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (f021ab2) to head (1c46ce4).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4116   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files         189      189           
  Lines       15667    15667           
=======================================
  Hits        14319    14319           
  Misses       1348     1348           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89

germa89 commented Jul 22, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@germa89
germa89 enabled auto-merge (squash) July 22, 2025 08:59

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
germa89 merged commit 94654a1 into main Jul 22, 2025
48 checks passed
@germa89
germa89 deleted the feat/plotting-psd-graphs branch July 22, 2025 08:59
@germa89 germa89 mentioned this pull request Jul 22, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display PSD input curve

3 participants