Skip to content

feat: add SECP command to PLOT_COMMANDS list - #4129

Merged
germa89 merged 3 commits into
mainfrom
feat/adding-secplot-to-plotting-commands
Jul 29, 2025
Merged

germa89 merged 3 commits into
mainfrom
feat/adding-secplot-to-plotting-commands

Conversation

@germa89

@germa89 germa89 commented Jul 29, 2025 •

Copy link
Copy Markdown
Collaborator

Description

As the title.

Issue linked

Related to #4127

Checklist

Summary by Sourcery

New Features:

  • Include SECP in the PLOT_COMMANDS list for plot command support

Copilot AI review requested due to automatic review settings July 29, 2025 10:58
@germa89
germa89 requested a review from a team as a code owner July 29, 2025 10:58
@germa89 germa89 self-assigned this Jul 29, 2025
@sourcery-ai

sourcery-ai Bot commented Jul 29, 2025 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

This PR updates the core API’s command registry by including the new SECP command in the PLOT_COMMANDS list, enabling section plotting functionality.

Class diagram for updated PLOT_COMMANDS list

classDiagram
    class mapdl_core {
        +PLOT_COMMANDS: List[str]
        +MAX_COMMAND_LENGTH: int
    }
    note for mapdl_core "PLOT_COMMANDS now includes 'SECP' for section plotting."
Loading

File-Level Changes

Change Details Files
Add SECP to supported plot commands
  • Appended “SECP” entry to the PLOT_COMMANDS list
src/ansys/mapdl/core/mapdl_core.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@germa89
germa89 enabled auto-merge (squash) July 29, 2025 10:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the SECP command to the PLOT_COMMANDS list in the PyMAPDL core module, enabling SECP to be recognized as a plotting command within the framework.

  • Adds "SECP" to the PLOT_COMMANDS list for proper command categorization
  • Maintains alphabetical ordering within the existing command list structure

Comment thread src/ansys/mapdl/core/mapdl_core.py Outdated
@germa89

germa89 commented Jul 29, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @germa89 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@github-actions github-actions Bot added the new feature Request or proposal for a new feature label Jul 29, 2025
@codecov

codecov Bot commented Jul 29, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.29%. Comparing base (9d5c186) to head (3bc0f44).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4129      +/-   ##
==========================================
+ Coverage   91.11%   91.29%   +0.17%     
==========================================
  Files         189      189              
  Lines       15650    15650              
==========================================
+ Hits        14260    14287      +27     
+ Misses       1390     1363      -27     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89
germa89 merged commit db31b73 into main Jul 29, 2025
@germa89
germa89 deleted the feat/adding-secplot-to-plotting-commands branch July 29, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature Request or proposal for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants